From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22032 invoked by alias); 24 May 2011 11:20:19 -0000 Received: (qmail 22024 invoked by uid 22791); 24 May 2011 11:20:18 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 24 May 2011 11:19:29 +0000 Received: (qmail 15923 invoked from network); 24 May 2011 11:19:28 -0000 Received: from unknown (HELO digraph.polyomino.org.uk) (joseph@127.0.0.2) by mail.codesourcery.com with ESMTPA; 24 May 2011 11:19:28 -0000 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.72) (envelope-from ) id 1QOpe3-0001SU-0G; Tue, 24 May 2011 11:19:27 +0000 Date: Tue, 24 May 2011 12:37:00 -0000 From: "Joseph S. Myers" To: Guozhi Wei cc: reply@codereview.appspotmail.com, dougkwan@google.com, jingyu@google.com, gcc-patches@gcc.gnu.org Subject: Re: [google] Disable getpagesize() for Android toolchain (issue4515131) In-Reply-To: <20110524093904.2498F2072D@guozhiwei.sha.corp.google.com> Message-ID: References: <20110524093904.2498F2072D@guozhiwei.sha.corp.google.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-05/txt/msg01714.txt.bz2 On Tue, 24 May 2011, Guozhi Wei wrote: > Index: getpagesize.c > =================================================================== > --- getpagesize.c (revision 174099) > +++ getpagesize.c (working copy) > @@ -60,11 +60,13 @@ BUGS > # endif /* PAGESIZE */ > #endif /* GNU_OUR_PAGESIZE */ > > +#if DEFAULT_LIBC != LIBC_BIONIC This makes no sense to me. getpagesize.c is in libiberty. libiberty does not include any GCC-specific headers - and in particular, does not include tm.h, which is where the definitions of DEFAULT_LIBC and LIBC_BIONIC would come from (via tm_defines in config.gcc). (In any case, I thought it was now accepted that libiberty should stop being built for the target, and obviously it doesn't make sense for this particular host-side functionality to depend on what the target is.) -- Joseph S. Myers joseph@codesourcery.com