From: "Joseph S. Myers" <joseph@codesourcery.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: gcc-patches@gcc.gnu.org, Uros Bizjak <ubizjak@gmail.com>
Subject: Re: PATCH [1/n]: Add initial -x32 support
Date: Tue, 07 Jun 2011 15:47:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.64.1106071545020.383@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20110605195441.GA1225@intel.com>
On Sun, 5 Jun 2011, H.J. Lu wrote:
> * config.gcc: Support --enable-x32/--enable-ia32 for x86 Linux
> targets.
>
> * configure.ac: Support --enable-x32/--enable-ia32.
> * configure: Regenerated.
New configure options need documenting in install.texi.
> #undef ASM_SPEC
> -#define ASM_SPEC "%{" SPEC_32 ":--32} %{" SPEC_64 ":--64} \
> +#define ASM_SPEC "%{" SPEC_32 ":%{!mx32:--32}} %{" \
> + SPEC_64 ":%{!mx32:--64}} %{mx32:--x32} \
> %{!mno-sse2avx:%{mavx:-msse2avx}} %{msse2avx:%{!mavx:-msse2avx}}"
This looks wrong. You should define SPEC_32, SPEC_64 and SPEC_X32 to be
the three mutually exclusive cases, then use those three here and in other
specs without any nesting.
> Generate code for a 32-bit or 64-bit environment.
> -The 32-bit environment sets int, long and pointer to 32 bits and
> +The -m32 option sets int, long and pointer to 32 bits and
@option{-m32}. Likewise later in this paragraph for various option names.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2011-06-07 15:47 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-05 19:55 H.J. Lu
2011-06-06 15:47 ` Uros Bizjak
2011-06-07 15:47 ` Joseph S. Myers [this message]
2011-06-07 18:54 ` H.J. Lu
2011-06-07 19:19 ` Joseph S. Myers
2011-06-07 15:59 ` Joseph S. Myers
2011-06-07 19:11 ` H.J. Lu
2011-06-07 19:20 ` Joseph S. Myers
2011-06-07 22:02 ` H.J. Lu
2011-06-14 17:52 ` H.J. Lu
2011-07-05 14:42 ` PATCH [1/n] X32: " H.J. Lu
2011-07-05 15:21 ` Uros Bizjak
2011-07-05 17:59 ` H.J. Lu
2011-07-05 18:18 ` Uros Bizjak
2011-07-05 19:09 ` H.J. Lu
2011-07-05 19:09 ` Joseph S. Myers
2011-07-05 20:07 ` Uros Bizjak
2011-07-06 14:50 ` H.J. Lu
2011-07-06 15:03 ` Richard Guenther
2011-07-06 16:40 ` H.J. Lu
2011-07-07 13:03 ` H.J. Lu
2011-07-07 13:08 ` Uros Bizjak
2011-07-07 13:27 ` Paolo Bonzini
2011-07-07 15:10 ` H.J. Lu
2011-07-07 15:14 ` Uros Bizjak
2011-07-07 15:38 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1106071545020.383@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hjl.tools@gmail.com \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).