From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9554 invoked by alias); 7 Jun 2011 15:47:43 -0000 Received: (qmail 9543 invoked by uid 22791); 7 Jun 2011 15:47:42 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 07 Jun 2011 15:47:29 +0000 Received: (qmail 21186 invoked from network); 7 Jun 2011 15:47:28 -0000 Received: from unknown (HELO digraph.polyomino.org.uk) (joseph@127.0.0.2) by mail.codesourcery.com with ESMTPA; 7 Jun 2011 15:47:28 -0000 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.72) (envelope-from ) id 1QTyV4-0000A5-U4; Tue, 07 Jun 2011 15:47:26 +0000 Date: Tue, 07 Jun 2011 15:47:00 -0000 From: "Joseph S. Myers" To: "H.J. Lu" cc: gcc-patches@gcc.gnu.org, Uros Bizjak Subject: Re: PATCH [1/n]: Add initial -x32 support In-Reply-To: <20110605195441.GA1225@intel.com> Message-ID: References: <20110605195441.GA1225@intel.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-06/txt/msg00538.txt.bz2 On Sun, 5 Jun 2011, H.J. Lu wrote: > * config.gcc: Support --enable-x32/--enable-ia32 for x86 Linux > targets. > > * configure.ac: Support --enable-x32/--enable-ia32. > * configure: Regenerated. New configure options need documenting in install.texi. > #undef ASM_SPEC > -#define ASM_SPEC "%{" SPEC_32 ":--32} %{" SPEC_64 ":--64} \ > +#define ASM_SPEC "%{" SPEC_32 ":%{!mx32:--32}} %{" \ > + SPEC_64 ":%{!mx32:--64}} %{mx32:--x32} \ > %{!mno-sse2avx:%{mavx:-msse2avx}} %{msse2avx:%{!mavx:-msse2avx}}" This looks wrong. You should define SPEC_32, SPEC_64 and SPEC_X32 to be the three mutually exclusive cases, then use those three here and in other specs without any nesting. > Generate code for a 32-bit or 64-bit environment. > -The 32-bit environment sets int, long and pointer to 32 bits and > +The -m32 option sets int, long and pointer to 32 bits and @option{-m32}. Likewise later in this paragraph for various option names. -- Joseph S. Myers joseph@codesourcery.com