From: Michael Matz <matz@suse.de>
To: Richard Guenther <richard.guenther@gmail.com>
Cc: Jakub Jelinek <jakub@redhat.com>, gcc-patches@gcc.gnu.org
Subject: Re: [4.6 PATCH] Workaround for stack slot sharing problems with unrolling (PR fortran/49103)
Date: Tue, 07 Jun 2011 13:49:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.64.1106071547580.9668@wotan.suse.de> (raw)
In-Reply-To: <BANLkTinrmv=rJDuh8T0sKtpO=eMEpiqNdg@mail.gmail.com>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 545 bytes --]
Hi,
On Tue, 7 Jun 2011, Richard Guenther wrote:
> > + Â Â Â Â tree base = get_base_address (lhs);
>
> Probably easier and more complete to do
>
> if (lhs && TREE_CODE (lhs) != SSA_NAME)
> {
> tree base = get_base_address (lhs);
>
>
> I don't like the patch too much, but it looks reasonable. At least
> reverting your patch doesn't really fix anything.
>
> Any opinions from others?
It's ugly. But ... well, IMHO such hacks are acceptable for released
branches.
Ciao,
Michael.
next prev parent reply other threads:[~2011-06-07 13:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-07 6:32 Jakub Jelinek
2011-06-07 10:24 ` Richard Guenther
2011-06-07 13:49 ` Michael Matz [this message]
2011-06-13 22:37 ` Jakub Jelinek
2011-06-14 10:16 ` Richard Guenther
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1106071547580.9668@wotan.suse.de \
--to=matz@suse.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).