From: "Joseph S. Myers" <joseph@codesourcery.com>
To: Janis Johnson <janisjo@codesourcery.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [testsuite] skip ARM neon-fp16 tests for other -mcpu values
Date: Wed, 08 Jun 2011 10:24:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.64.1106081014340.12752@digraph.polyomino.org.uk> (raw)
In-Reply-To: <4DEECB2D.9000403@codesourcery.com>
On Tue, 7 Jun 2011, Janis Johnson wrote:
> These tests fail when multilib options use -mfpu=xxxx and override the
> -mfpu=neon-fp16 used for the test:
>
> g++.dg/ext/arm-fp16/arm-fp16-ops-5.C
> g++.dg/ext/arm-fp16/arm-fp16-ops-6.C
> gcc.dg/torture/arm-fp16-ops-5.c
> gcc.dg/torture/arm-fp16-ops-6.c
> gcc.target/arm/fp16-compile-vcvt.c
>
> The option -mfpu-neon-fp16 is added via "dg-add-options arm_neon_fp16"
> after an earlier "dg-require-effective-target arm_neon_fp16_ok".
> This patch modifies check_effective_target_arm_neon_fp16_ok_nocache to
> return 0 (causing the test to be skipped) if multilib flags include
> -mfpu= with a value other than neon-fp16.
But I'd think they ought to work with any -mfpu= option supporting
half-precision instructions - that is, vfpv3-fp16, vfpv3-d16-fp16,
vfpv3xd-fp16, neon-fp16, vfpv4, vfpv4-d16, fpv4-sp-d16, neon-vfpv4
(anything with "true" in the last field in arm-fpus.def; for the
testsuite, you can probably suppose anything -mfpu=*fp16*,
-mfpu=*fpv[4-9]*, -mfpu=*fpv[1-9][0-9]*).
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2011-06-08 10:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-08 1:29 Janis Johnson
2011-06-08 2:05 ` Mike Stump
2011-06-08 2:14 ` Janis Johnson
2011-06-08 10:24 ` Joseph S. Myers [this message]
2011-06-08 16:16 ` Janis Johnson
2011-06-10 0:04 ` Janis Johnson
2011-06-15 13:07 ` Richard Earnshaw
2011-06-16 6:28 ` Janis Johnson
2011-06-26 4:29 ` Mike Stump
2011-06-27 5:08 ` Janis Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1106081014340.12752@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=janisjo@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).