From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2101 invoked by alias); 9 Jun 2011 14:37:06 -0000 Received: (qmail 2003 invoked by uid 22791); 9 Jun 2011 14:37:05 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 09 Jun 2011 14:36:46 +0000 Received: (qmail 6090 invoked from network); 9 Jun 2011 14:36:45 -0000 Received: from unknown (HELO digraph.polyomino.org.uk) (joseph@127.0.0.2) by mail.codesourcery.com with ESMTPA; 9 Jun 2011 14:36:45 -0000 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.72) (envelope-from ) id 1QUgLj-0002w6-7c; Thu, 09 Jun 2011 14:36:43 +0000 Date: Thu, 09 Jun 2011 14:53:00 -0000 From: "Joseph S. Myers" To: Pierre Vittet cc: gcc-patches@gcc.gnu.org, tromey@redhat.com, Basile Starynkevitch Subject: Re: [PATCH] c-pragma: adding a data field to pragma_handler In-Reply-To: <4DF08B94.1010804@pvittet.com> Message-ID: References: <4DE66ECE.5030102@laposte.net> <4DE8FE4D.6050404@pvittet.com> <4DEFE90F.5020607@pvittet.com> <20110609081635.6a3c0ad2.basile@starynkevitch.net> <4DF08B94.1010804@pvittet.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-06/txt/msg00738.txt.bz2 Thanks for this patch. You need to adjust the formatting of the comments to match the existing style (in particular, indentation of second and subsequent lines of comments, and watch out for spelling errors (exemple, abstact). For a struct, the explanations of individual fields should be in the comments on those fields rather than at the top of the struct. The comment on c_register_pragma_with_data should refer to c_register_pragma_with_expansion_and_data rather than c_register_pragma_with_expansion. -- Joseph S. Myers joseph@codesourcery.com