From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 763 invoked by alias); 15 Jun 2011 14:11:45 -0000 Received: (qmail 755 invoked by uid 22791); 15 Jun 2011 14:11:44 -0000 X-SWARE-Spam-Status: No, hits=-3.2 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from cantor2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 15 Jun 2011 14:11:16 +0000 Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.221.2]) by mx2.suse.de (Postfix) with ESMTP id 2F31489783; Wed, 15 Jun 2011 16:11:15 +0200 (CEST) Date: Wed, 15 Jun 2011 14:37:00 -0000 From: Michael Matz To: "H.J. Lu" Cc: gcc-patches@gcc.gnu.org Subject: Re: PATCH [5/n]: Prepare x32: PR middle-end/48016: Inconsistency in non-local goto save area In-Reply-To: <20110611160548.GA20036@intel.com> Message-ID: References: <20110611160548.GA20036@intel.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-06/txt/msg01160.txt.bz2 Hi, On Sat, 11 Jun 2011, H.J. Lu wrote: > We are very inconsistent when saving and restoring non-local goto save > area. See: > > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48016 > > for detailed analysis. OK for trunk? > + /* FIXME: update_nonlocal_goto_save_area may pass SA in the wrong mode. */ > + if (GET_MODE (sa) != mode) > + { > + gcc_assert (ptr_mode != Pmode > + && GET_MODE (sa) == ptr_mode > + && mode == Pmode); > + sa = adjust_address (sa, mode, 0); > + } That may be appropriate for a branch, but trunk shouldn't contain FIXMEs that explain how something should be fixed, instead that something should be carried out. I.e. just fix update_nonlocal_goto_save_area. Ciao, Michael.