From: "Joseph S. Myers" <joseph@codesourcery.com>
To: Janis Johnson <janisjo@codesourcery.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Mike Stump <mikestump@comcast.net>
Subject: Re: [testsuite] dg-final object-size: fail if file does not exist
Date: Thu, 16 Jun 2011 23:55:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.64.1106162316040.28136@digraph.polyomino.org.uk> (raw)
In-Reply-To: <4DFA7FF9.9060007@codesourcery.com>
On Thu, 16 Jun 2011, Janis Johnson wrote:
> Currently there are several possible causes for failure in object-size.
> Some are errors in the test itself, like the wrong number of arguments,
> but some others could be UNRESOLVED instead of ERROR, such as the "size"
> command failing or producing unexpected output. Can the UNRESOLVED line
> include additional information about the reason for the failure, or
> should the reason just be in a message in the log file?
My view is that reasons should be separately in the log file; there should
be a fixed set of test names, each of which may be PASS, FAIL, UNRESOLVED
etc. in a particular test run. (I know the code reporting ICEs in test
names doesn't conform to this; properly that should have separate "test
for internal compiler error" test names rather than modifying the name of
a failing test if it has an ICE.)
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2011-06-16 23:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-16 17:07 Janis Johnson
2011-06-16 17:26 ` Joseph S. Myers
2011-06-16 23:12 ` Janis Johnson
2011-06-16 23:55 ` Joseph S. Myers [this message]
2011-06-17 1:09 ` Janis Johnson
2011-06-18 14:50 ` Mike Stump
2011-06-16 20:38 ` Mike Stump
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1106162316040.28136@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=janisjo@codesourcery.com \
--cc=mikestump@comcast.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).