From: "Joseph S. Myers" <joseph@codesourcery.com>
To: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Cc: gcc-patches@gcc.gnu.org, Paolo Bonzini <bonzini@gnu.org>,
Ralf Wildenhues <Ralf.Wildenhues@gmx.de>,
Ian Lance Taylor <iant@google.com>,
Steve Ellcey <sje@cup.hp.com>,
Richard Earnshaw <richard.earnshaw@arm.com>,
Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>,
Nick Clifton <nickc@redhat.com>, Douglas Rupp <rupp@gnat.com>,
Tristan Gingold <gingold@adacore.com>,
Mike Stump <mikestump@comcast.net>,
Kaz Kojima <kkojima@gcc.gnu.org>,
David Edelsohn <dje.gcc@gmail.com>,
Sterling Augustine <augustine.sterling@gmail.com>,
Arnaud Charlet <charlet@adacore.com>,
java-patches@gcc.gnu.org,
Nicola Pero <nicola.pero@meta-innovation.com>,
libstdc++@gcc.gnu.org,
Richard Sandiford <rdsandiford@googlemail.com>
Subject: Re: [build] Move unwinder to toplevel libgcc
Date: Mon, 20 Jun 2011 15:21:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.64.1106201503490.16125@digraph.polyomino.org.uk> (raw)
In-Reply-To: <yddfwn4pu5u.fsf@manam.CeBiTec.Uni-Bielefeld.DE>
On Mon, 20 Jun 2011, Rainer Orth wrote:
> * Move all remaining unwinder-only macros to libgcc: UNW_IVMS_MODE,
> MD_UNW_COMPATIBLE_PERSONALITY_P, MD_FROB_UPDATE_CONTEXT.
I don't see any sign of macros being poisoned in system.h. For macros
used in target-independent unwinder code - at least MD_FROB_UPDATE_CONTEXT
- that used to be defined in the host tm.h but now no longer should be, I
think poisoning in system.h is appropriate.
> * The only unwinder-related macro I haven't moved is
> LIBGCC2_UNWIND_ATTRIBUTE. It is only defined gcc/config/mips/mips.h.
> I suppose we would need a libgcc equivalent of tm.h for that,
> something I didn't want to attack at this point.
What about DWARF_ZERO_REG and PRE_GCC3_DWARF_FRAME_REGISTERS?
DWARF_REG_TO_UNWIND_COLUMN may be more complicated because it's used on
the host in rs6000.c (although not in target-independent host code) as
well as on the target - I suspect that will be a case where duplicating
the definition (with a comment in one place pointing to the other place as
needing to be kept consistent, and with the host-side copy renamed to
facilitate poisoning) may make sense. And all three are defined in
<arch>.h headers so your reason for moving them separately may apply.
(There are lots more macros used in the unwinder and on the host for which
macros predefined with -fbuilding-libgcc may be appropriate in a later
patch.)
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2011-06-20 15:11 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-20 12:44 Rainer Orth
2011-06-20 15:21 ` Joseph S. Myers [this message]
2011-06-20 15:23 ` Rainer Orth
2011-06-20 15:37 ` Joseph S. Myers
2011-06-20 15:47 ` Rainer Orth
2011-07-04 18:10 ` CFT: " Rainer Orth
2011-07-05 9:35 ` Tristan Gingold
2011-07-07 13:11 ` Rainer Orth
2011-07-07 15:53 ` Steve Ellcey
2011-07-08 18:16 ` Rainer Orth
2011-07-07 16:48 ` Steve Ellcey
2011-07-08 18:24 ` Rainer Orth
2011-07-07 17:08 ` Steve Ellcey
2011-07-07 22:55 ` Steve Ellcey
2011-07-08 18:55 ` Rainer Orth
2011-07-08 20:18 ` Steve Ellcey
2011-07-12 17:24 ` Steve Ellcey
2011-07-12 17:40 ` Rainer Orth
2011-07-12 17:42 ` Steve Ellcey
2011-07-14 1:47 ` Steve Ellcey
2011-07-15 9:38 ` Rainer Orth
2011-07-18 12:07 ` Rainer Orth
2011-07-18 17:50 ` Steve Ellcey
2011-07-19 11:43 ` Rainer Orth
2011-07-20 23:03 ` Steve Ellcey
2011-07-22 15:36 ` Rainer Orth
2011-07-22 18:56 ` Steve Ellcey
2011-07-22 19:03 ` Rainer Orth
2011-07-22 22:20 ` Steve Ellcey
2011-07-25 17:07 ` Rainer Orth
2011-06-29 10:05 ` [build] " Paolo Bonzini
2011-06-29 10:06 ` Rainer Orth
2011-06-29 11:29 ` Joseph S. Myers
2011-06-29 11:33 ` Paolo Bonzini
2011-06-29 12:40 ` Rainer Orth
2011-06-29 12:17 ` Rainer Orth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1106201503490.16125@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=Ralf.Wildenhues@gmx.de \
--cc=augustine.sterling@gmail.com \
--cc=bonzini@gnu.org \
--cc=charlet@adacore.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gingold@adacore.com \
--cc=iant@google.com \
--cc=java-patches@gcc.gnu.org \
--cc=kkojima@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
--cc=mikestump@comcast.net \
--cc=nickc@redhat.com \
--cc=nicola.pero@meta-innovation.com \
--cc=ramana.radhakrishnan@arm.com \
--cc=rdsandiford@googlemail.com \
--cc=richard.earnshaw@arm.com \
--cc=ro@CeBiTec.Uni-Bielefeld.DE \
--cc=rupp@gnat.com \
--cc=sje@cup.hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).