From: Michael Matz <matz@suse.de>
To: "William J. Schmidt" <wschmidt@linux.vnet.ibm.com>
Cc: Richard Guenther <rguenther@suse.de>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH][RFC][1/2] Bitfield lowering, add BIT_FIELD_EXPR
Date: Mon, 20 Jun 2011 13:44:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.64.1106201533190.17115@wotan.suse.de> (raw)
In-Reply-To: <1308526874.8025.5.camel@gnopaine>
Hi,
On Sun, 19 Jun 2011, William J. Schmidt wrote:
> At the risk of being obvious...it seems you could easily combine C1 and
> C2 into a single "bitfield descriptor" TREE_INT_CST operand by using
> both the high and low portions of the constant. Accessor macros could
> be used to hide the slight hackishness of the solution. I didn't see
> anything in either patch where this would look particularly ugly.
Agreed. I don't even see it as hackish, it's quite normal that the
implementation of data structures actually uses a different layout than a
completely orthogonal one. As long as the accessors are looking
orthogonal.
Ciao,
Michael.
prev parent reply other threads:[~2011-06-20 13:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-16 11:46 Richard Guenther
2011-06-16 12:06 ` Jay Foad
2011-06-16 17:18 ` Richard Henderson
2011-06-16 18:10 ` Eric Botcazou
2011-06-16 19:23 ` Richard Guenther
2011-06-16 19:53 ` Richard Henderson
2011-06-20 14:23 ` William J. Schmidt
2011-06-20 19:09 ` Andrew Pinski
2011-06-20 21:03 ` Richard Guenther
2011-06-20 21:05 ` Andrew Pinski
2011-06-19 23:45 ` William J. Schmidt
2011-06-20 13:44 ` Michael Matz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1106201533190.17115@wotan.suse.de \
--to=matz@suse.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=rguenther@suse.de \
--cc=wschmidt@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).