From: "Joseph S. Myers" <joseph@codesourcery.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: gcc-patches@gcc.gnu.org, Jason Merrill <jason@redhat.com>,
Richard Henderson <rth@redhat.com>
Subject: Re: PATCH [8/n]: Prepare x32: PR other/48007: Unwind library doesn't work with UNITS_PER_WORD > sizeof (void *)
Date: Sat, 25 Jun 2011 23:34:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.64.1106252016250.27066@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20110625161357.GA5401@intel.com>
On Sat, 25 Jun 2011, H.J. Lu wrote:
> +#ifndef UNIQUE_UNWIND_CONTEXT
The use of #ifndef seems to imply that this is a target macro, to be
defined in libgcc_tm.h. In that case it should be documented, and
poisoned in system.h under the "only used for code built for the target"
case, and this:
> +#if defined __x86_64 && !defined __LP64__
is inappropriate since you should instead put it in an appropriate header
in libgcc/config/, rather than hardcoding an architecture-specific #if in
an architecture-independent file.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2011-06-25 20:19 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-25 17:02 H.J. Lu
2011-06-25 23:34 ` Joseph S. Myers [this message]
2011-06-25 23:36 ` H.J. Lu
2011-06-26 20:06 ` Jason Merrill
2011-06-26 20:22 ` Jason Merrill
2011-06-26 21:45 ` H.J. Lu
2011-06-27 2:12 ` Jason Merrill
2011-06-27 3:17 ` H.J. Lu
2011-06-27 15:16 ` Jason Merrill
2011-06-28 19:25 ` H.J. Lu
2011-06-30 14:46 ` Jason Merrill
2011-06-30 14:53 ` H.J. Lu
2011-06-30 15:26 ` Jason Merrill
2011-06-30 16:36 ` H.J. Lu
2011-06-30 17:57 ` H.J. Lu
2011-06-30 18:01 ` H.J. Lu
2011-06-30 18:10 ` Rainer Orth
2011-06-30 18:19 ` H.J. Lu
2011-06-30 18:42 ` Rainer Orth
2011-06-30 20:14 ` H.J. Lu
2011-06-30 20:24 ` Richard Henderson
2011-06-30 21:51 ` H.J. Lu
2011-07-01 9:03 ` Rainer Orth
2011-07-01 12:51 ` H.J. Lu
2011-07-01 13:37 ` Rainer Orth
2011-07-01 13:42 ` H.J. Lu
2011-07-01 14:03 ` Rainer Orth
2011-07-01 14:06 ` H.J. Lu
2011-07-01 14:25 ` Rainer Orth
2011-07-01 14:55 ` H.J. Lu
2011-08-02 21:02 ` Jason Merrill
2011-08-02 22:27 ` H.J. Lu
2011-08-03 21:47 ` Jason Merrill
2011-06-30 20:59 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1106252016250.27066@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hjl.tools@gmail.com \
--cc=jason@redhat.com \
--cc=rth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).