From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29146 invoked by alias); 25 Jun 2011 20:19:22 -0000 Received: (qmail 29136 invoked by uid 22791); 25 Jun 2011 20:19:21 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 25 Jun 2011 20:19:08 +0000 Received: (qmail 14912 invoked from network); 25 Jun 2011 20:19:08 -0000 Received: from unknown (HELO digraph.polyomino.org.uk) (joseph@127.0.0.2) by mail.codesourcery.com with ESMTPA; 25 Jun 2011 20:19:08 -0000 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.72) (envelope-from ) id 1QaZJp-00074U-UK; Sat, 25 Jun 2011 20:19:05 +0000 Date: Sat, 25 Jun 2011 23:34:00 -0000 From: "Joseph S. Myers" To: "H.J. Lu" cc: gcc-patches@gcc.gnu.org, Jason Merrill , Richard Henderson Subject: Re: PATCH [8/n]: Prepare x32: PR other/48007: Unwind library doesn't work with UNITS_PER_WORD > sizeof (void *) In-Reply-To: <20110625161357.GA5401@intel.com> Message-ID: References: <20110625161357.GA5401@intel.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-06/txt/msg01923.txt.bz2 On Sat, 25 Jun 2011, H.J. Lu wrote: > +#ifndef UNIQUE_UNWIND_CONTEXT The use of #ifndef seems to imply that this is a target macro, to be defined in libgcc_tm.h. In that case it should be documented, and poisoned in system.h under the "only used for code built for the target" case, and this: > +#if defined __x86_64 && !defined __LP64__ is inappropriate since you should instead put it in an appropriate header in libgcc/config/, rather than hardcoding an architecture-specific #if in an architecture-independent file. -- Joseph S. Myers joseph@codesourcery.com