From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9006 invoked by alias); 26 Jun 2011 14:28:31 -0000 Received: (qmail 8998 invoked by uid 22791); 26 Jun 2011 14:28:30 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,TW_GX,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 26 Jun 2011 14:28:13 +0000 Received: (qmail 5639 invoked from network); 26 Jun 2011 14:28:13 -0000 Received: from unknown (HELO digraph.polyomino.org.uk) (joseph@127.0.0.2) by mail.codesourcery.com with ESMTPA; 26 Jun 2011 14:28:13 -0000 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.72) (envelope-from ) id 1QaqJm-00012O-32; Sun, 26 Jun 2011 14:28:10 +0000 Date: Sun, 26 Jun 2011 14:53:00 -0000 From: "Joseph S. Myers" To: Chris Demetriou cc: reply@codereview.appspotmail.com, gcc-patches@gcc.gnu.org Subject: Re: [trunk] RFA: translate built-in include paths for sysroot (issue4641076) In-Reply-To: <20110626060843.544C11E8175@cgda.mtv.corp.google.com> Message-ID: References: <20110626060843.544C11E8175@cgda.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-06/txt/msg01936.txt.bz2 On Sat, 25 Jun 2011, Chris Demetriou wrote: > For the C headers, add_standard_paths prepends the sysroot location to > the /usr/include path (since that's what's specified in cppdefault.c for > that path). It doesn't do the same for the C++ include path, though > (again, as specified in cppdefault.c). It seems to me that what's really wanted here is to change the add_sysroot flag for the C++ path (all of the C++ paths?), rather than adding special code to detect paths starting with the sysroot and reinterpret them. And so making configure detect when the --with-gxx-include-dir setting starts with the sysroot and adjusting the flag accordingly in that case would be a cleaner solution - that way it would be obvious that the semantics of the relocation are exactly the same as for other sysrooted paths, whereas it isn't when the relocation goes through different code paths in the compiler. -- Joseph S. Myers joseph@codesourcery.com