From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8738 invoked by alias); 29 Jun 2011 16:16:36 -0000 Received: (qmail 8729 invoked by uid 22791); 29 Jun 2011 16:16:34 -0000 X-SWARE-Spam-Status: No, hits=-3.2 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from cantor2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 29 Jun 2011 16:16:20 +0000 Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.221.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id D17118B45E; Wed, 29 Jun 2011 18:16:18 +0200 (CEST) Date: Wed, 29 Jun 2011 17:03:00 -0000 From: Michael Matz To: "H.J. Lu" Cc: Richard Guenther , gcc-patches@gcc.gnu.org Subject: Re: PATCH [5/n]: Prepare x32: PR middle-end/48016: Inconsistency in non-local goto save area In-Reply-To: Message-ID: References: <20110611160548.GA20036@intel.com> MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="168427776-1946123287-1309363884=:17115" Content-ID: X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-06/txt/msg02256.txt.bz2 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --168427776-1946123287-1309363884=:17115 Content-Type: TEXT/PLAIN; CHARSET=utf-8 Content-Transfer-Encoding: 8BIT Content-ID: Content-length: 1121 Hi, On Wed, 29 Jun 2011, H.J. Lu wrote: > > diff --git a/gcc/function.c b/gcc/function.c > > index 81c4d39..131bc09 100644 > > --- a/gcc/function.c > > +++ b/gcc/function.c > > @@ -4780,7 +4780,7 @@ expand_function_start (tree subr) > >                       cfun->nonlocal_goto_save_area, > >                       integer_zero_node, NULL_TREE, NULL_TREE); > >       r_save = expand_expr (t_save, NULL_RTX, VOIDmode, EXPAND_WRITE); > > -      r_save = convert_memory_address (Pmode, r_save); > > +      r_save = adjust_address (r_save, Pmode, 0); This is actually the same problem as in explow.c. t_save is built with ptr_type_node, where it should have been using TREE_TYPE (TREE_TYPE (cfun->nonlocal_goto_save_area)) Then r_save should have the correct mode already, possibly this could be asserted. You are right that r_save needs to correspond to the nonlocal_goto_save_area[0] array-ref, hence pseudos aren't okay, therefore convert_memory_address isn't. Actually I think we might even want to assert that indeed the expanded r_save is of Pmode already. Ciao, Michael. --168427776-1946123287-1309363884=:17115--