From: Michael Matz <matz@suse.de>
To: Kai Tietz <ktietz70@googlemail.com>
Cc: Richard Guenther <richard.guenther@gmail.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [patch tree-optimization]: [3 of 3]: Boolify compares & more
Date: Fri, 08 Jul 2011 16:45:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.64.1107081825110.14485@wotan.suse.de> (raw)
In-Reply-To: <CAEwic4YDkH+pLLZvmVBNv9s2-5n6s2cztSsXpj10hjO7G0AFQg@mail.gmail.com>
Hi,
On Fri, 8 Jul 2011, Kai Tietz wrote:
> This is the reworked patch, It fixes vrp to handle bitwise one-bit
> precision typed operations and to handle some type hoisting cases, Some
> cases can't be handled as long as vrp doesn't allows to insert new
> statements in folding pass. To have in first pass better match, VRP uses
> for stmt-folding now for each BB first -> last stepping. I extended for
> this function substitute_and_fold function by an new argument, which
> indicates if scanning within BB shall be done from first to last, or
> from last to first. I removed in this new patch the part of re-doing
> stmt-fold pass, as this is no longer necessary by changing folding
> direction within BB.
You still add BIT_IOR_EXPR for POINTER_TYPE_P, which seems strange. All
these test for TYPE_PRECISION being 1 (and then handling BIT_IOR/AND_EXPR
like TRUTH_IOR/AND_EXPR) aren't necessary if you extend the general
handling for BIT_IOR_EXPR (for instance) to deal with not only constant
1, but simply handling all-ones constants specially. That is replace
integer_onep with integer_all_onesp at certain places.
Because also for wider than 1-bit precision it's the case that we can
infer usefull ranges out of "VARYING | all-ones".
Certainly the special casing on 1-bit is ugly. Work towards making
tree-vrp more lean and handling cases more general instead of piling
special case over special case.
Ciao,
Michael.
next prev parent reply other threads:[~2011-07-08 16:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-07 16:14 Kai Tietz
2011-07-07 16:19 ` Paolo Bonzini
2011-07-07 16:28 ` Kai Tietz
2011-07-08 9:45 ` Richard Guenther
2011-07-08 10:59 ` Kai Tietz
2011-07-08 11:08 ` Kai Tietz
2011-07-08 14:40 ` Kai Tietz
2011-07-08 14:57 ` Richard Guenther
2011-07-08 15:05 ` Kai Tietz
2011-07-08 9:39 ` Richard Guenther
2011-07-08 15:49 ` Kai Tietz
2011-07-08 16:31 ` Kai Tietz
2011-07-08 16:45 ` Michael Matz [this message]
2011-07-08 17:26 ` Kai Tietz
2011-07-12 17:18 ` Kai Tietz
2011-07-13 11:06 ` Richard Guenther
2011-07-15 7:59 ` Kai Tietz
2011-07-19 12:24 ` Richard Guenther
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1107081825110.14485@wotan.suse.de \
--to=matz@suse.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=ktietz70@googlemail.com \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).