* [google] Remove timestamped line from gengtype state file comment headers
@ 2011-08-23 14:40 Simon Baldwin
2011-08-23 14:47 ` Richard Guenther
0 siblings, 1 reply; 4+ messages in thread
From: Simon Baldwin @ 2011-08-23 14:40 UTC (permalink / raw)
To: gcc-patches; +Cc: dnovillo
Remove the timestamped line from gengtype state file comment headers.
Gcc builds after r177358 include a file .../plugin/gtype.state as part of
their binary installation. The file contains a comment line that includes
the current date and time. Variations in the file contents due to only
changes in the timestamp can be an issue for build and packaging systems
that prefer or insist on binary compatibility.
This patch removes the comment line, to provide binary reproducibility for
any generated gtype.state files.
Tested for x86 and PowerPC, no bootstrap in both cases.
OK for google/integration? Also, OK for trunk?
libstdc++-v3/ChangeLog:
2011-05-20 Simon Baldwin <simonb@google.com>
* scripts/extract_symvers.in: Handle processor/OS specific or
unknown symbol binding strings from readelf.
Index: gcc/gengtype-state.c
===================================================================
--- gcc/gengtype-state.c (revision 177984)
+++ gcc/gengtype-state.c (working copy)
@@ -1194,8 +1194,6 @@ write_state (const char *state_path)
fprintf (state_file,
";;; This file should be parsed by the same %s which wrote it.\n",
progname);
- fprintf (state_file, ";;; file %s generated on %s\n", state_path,
- ctime (&now));
/* The first non-comment significant line gives the version string. */
write_state_version (version_string);
write_state_srcdir ();
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [google] Remove timestamped line from gengtype state file comment headers
2011-08-23 14:40 [google] Remove timestamped line from gengtype state file comment headers Simon Baldwin
@ 2011-08-23 14:47 ` Richard Guenther
2011-08-23 14:50 ` Michael Matz
0 siblings, 1 reply; 4+ messages in thread
From: Richard Guenther @ 2011-08-23 14:47 UTC (permalink / raw)
To: Simon Baldwin; +Cc: gcc-patches, dnovillo
On Tue, Aug 23, 2011 at 2:36 PM, Simon Baldwin <simonb@google.com> wrote:
> Remove the timestamped line from gengtype state file comment headers.
>
> Gcc builds after r177358 include a file .../plugin/gtype.state as part of
> their binary installation. The file contains a comment line that includes
> the current date and time. Variations in the file contents due to only
> changes in the timestamp can be an issue for build and packaging systems
> that prefer or insist on binary compatibility.
>
> This patch removes the comment line, to provide binary reproducibility for
> any generated gtype.state files.
>
> Tested for x86 and PowerPC, no bootstrap in both cases.
>
> OK for google/integration? Also, OK for trunk?
Ok for trunk.
Richard.
> libstdc++-v3/ChangeLog:
> 2011-05-20 Simon Baldwin <simonb@google.com>
>
> * scripts/extract_symvers.in: Handle processor/OS specific or
> unknown symbol binding strings from readelf.
>
>
> Index: gcc/gengtype-state.c
> ===================================================================
> --- gcc/gengtype-state.c (revision 177984)
> +++ gcc/gengtype-state.c (working copy)
> @@ -1194,8 +1194,6 @@ write_state (const char *state_path)
> fprintf (state_file,
> ";;; This file should be parsed by the same %s which wrote it.\n",
> progname);
> - fprintf (state_file, ";;; file %s generated on %s\n", state_path,
> - ctime (&now));
> /* The first non-comment significant line gives the version string. */
> write_state_version (version_string);
> write_state_srcdir ();
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [google] Remove timestamped line from gengtype state file comment headers
2011-08-23 14:47 ` Richard Guenther
@ 2011-08-23 14:50 ` Michael Matz
2011-08-23 15:17 ` Simon Baldwin
0 siblings, 1 reply; 4+ messages in thread
From: Michael Matz @ 2011-08-23 14:50 UTC (permalink / raw)
To: Richard Guenther; +Cc: Simon Baldwin, gcc-patches, dnovillo
[-- Attachment #1: Type: TEXT/PLAIN, Size: 617 bytes --]
Hi,
On Tue, 23 Aug 2011, Richard Guenther wrote:
> > This patch removes the comment line, to provide binary reproducibility for
> > any generated gtype.state files.
> >
> > Tested for x86 and PowerPC, no bootstrap in both cases.
> >
> > OK for google/integration? Â Also, OK for trunk?
>
> Ok for trunk.
But perhaps with a different ChangeLog entry :)
> > libstdc++-v3/ChangeLog:
> > 2011-05-20  Simon Baldwin  <simonb@google.com>
> >
> > Â Â Â Â * scripts/extract_symvers.in: Handle processor/OS specific or
> > Â Â Â Â unknown symbol binding strings from readelf.
Ciao,
Michael.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [google] Remove timestamped line from gengtype state file comment headers
2011-08-23 14:50 ` Michael Matz
@ 2011-08-23 15:17 ` Simon Baldwin
0 siblings, 0 replies; 4+ messages in thread
From: Simon Baldwin @ 2011-08-23 15:17 UTC (permalink / raw)
To: Michael Matz; +Cc: Richard Guenther, gcc-patches, dnovillo
On 23 August 2011 15:34, Michael Matz <matz@suse.de> wrote:
>
> Hi,
>
> On Tue, 23 Aug 2011, Richard Guenther wrote:
>
> > > This patch removes the comment line, to provide binary reproducibility for
> > > any generated gtype.state files.
> > >
> > > Tested for x86 and PowerPC, no bootstrap in both cases.
> > >
> > > OK for google/integration? Also, OK for trunk?
> >
> > Ok for trunk.
>
> But perhaps with a different ChangeLog entry :)
Heh! Thanks, yes. Plainly I'm out of practice with gcc patches.
Corrected version below, for completeness.
--
Remove the timestamped line from gengtype state file comment headers.
Gcc builds after r177358 include a file .../plugin/gtype.state as part of
their binary installation. The file contains a comment line that includes
the current date and time. Variations in the file contents due to only
changes in the timestamp can be an issue for build and packaging systems
that prefer or insist on binary compatibility.
This patch removes the comment line, to provide binary reproducibility for
any generated gtype.state files.
Tested for x86 and PowerPC, no bootstrap in both cases.
OK for google/integration? Also, OK for trunk?
gcc/ChangeLog:
2011-08-23 Simon Baldwin <simonb@google.com>
* gengtype-state.c (write_state): Remove timestamped header line.
Index: gcc/gengtype-state.c
===================================================================
--- gcc/gengtype-state.c (revision 177984)
+++ gcc/gengtype-state.c (working copy)
@@ -1194,8 +1194,6 @@ write_state (const char *state_path)
fprintf (state_file,
";;; This file should be parsed by the same %s which wrote it.\n",
progname);
- fprintf (state_file, ";;; file %s generated on %s\n", state_path,
- ctime (&now));
/* The first non-comment significant line gives the version string. */
write_state_version (version_string);
write_state_srcdir ();
--
Google UK Limited | Registered Office: Belgrave House, 76 Buckingham
Palace Road, London SW1W 9TQ | Registered in England Number: 3977902
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-08-23 14:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-08-23 14:40 [google] Remove timestamped line from gengtype state file comment headers Simon Baldwin
2011-08-23 14:47 ` Richard Guenther
2011-08-23 14:50 ` Michael Matz
2011-08-23 15:17 ` Simon Baldwin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).