public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "Joseph S. Myers" <joseph@codesourcery.com>
To: Gary Funck <gary@intrepid.com>
Cc: Gcc Patches <gcc-patches@gcc.gnu.org>
Subject: Re: options generation and language count
Date: Tue, 30 Aug 2011 19:59:00 -0000	[thread overview]
Message-ID: <Pine.LNX.4.64.1108301657220.23667@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20110830160649.GM31092@intrepid.com>

On Tue, 30 Aug 2011, Gary Funck wrote:

> On 08/30/11 15:52:12, Joseph S. Myers wrote:
> > Please send a patch. [... on points 1, 2, and 3]0
> 
> OK, will do.
> 
> > GF: Also, the use of fixed masks is problematic.  Perhaps the AWK script
> > GF: could be changed to also generate values for CL_PARAMS, etc., ensuring
> > GF: that will not conflict with the language mask values?
> > 
> > That sounds riskier (and does everywhere using opts.h actually need the 
> > generated options.h as well?)
> 
> It looks like many files include opts.h, but do not include options.h.

options.h is also included via flags.h or tm.h.  (The dependencies between 
these headers are rather a mess.)

> > although in principle it ought to be 
> > possible to assign this automatically (and actually only CL_DRIVER, 
> > CL_TARGET and CL_COMMON should really need bits assigned, though avoiding 
> > the others would require a --help rework).
> 
> An alternative might be to move the fixed assignments (CL_DRIVER, 
> CL_TARGET, CL_COMMON ...) down to start at the beginning of the range,
> (leaving room for a few more) and to start the auto-generated
> language mask bits above that?

You could do that - again, you'd need to watch for existing dependencies 
on the ordering.

-- 
Joseph S. Myers
joseph@codesourcery.com

  reply	other threads:[~2011-08-30 16:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-30  6:57 Gary Funck
2011-08-30 16:50 ` Joseph S. Myers
2011-08-30 16:50   ` Gary Funck
2011-08-30 19:59     ` Joseph S. Myers [this message]
2011-09-01 21:49       ` [Patch, C] " Gary Funck
2011-09-02 13:42         ` Joseph S. Myers
2011-09-02 16:27           ` Gary Funck
2011-09-02 19:53             ` Joseph S. Myers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.1108301657220.23667@digraph.polyomino.org.uk \
    --to=joseph@codesourcery.com \
    --cc=gary@intrepid.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).