public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Michael Matz <matz@suse.de>
To: Richard Guenther <rguenther@suse.de>
Cc: Jakub Jelinek <jakub@redhat.com>,
	gcc-patches@gcc.gnu.org,	Andrew Pinski <pinskia@gmail.com>
Subject: Re: [PATCH] Handle COND_EXPR/VEC_COND_EXPR in walk_stmt_load_store_addr_ops and ssa verification
Date: Fri, 14 Oct 2011 14:26:00 -0000	[thread overview]
Message-ID: <Pine.LNX.4.64.1110141558430.20082@wotan.suse.de> (raw)
In-Reply-To: <alpine.LNX.2.00.1110141028070.308@zhemvz.fhfr.qr>

Hi,

On Fri, 14 Oct 2011, Richard Guenther wrote:

> But I'm not sure.  I think we should delete this check from
> verify_ssa and instead have a corresponding check in
> verify_stmts (which already properly walks trees) that
> for an SSA name we encounter we do have a properly linked use
> (see verify_expr, maybe it's easy to do that for the SSA_NAME
> case - at least it's easy without trying to avoid a
> FOR_EACH_SSA_USE_OPERAND (, SSA_OP_USE) on the stmt for
> each SSA_NAME we encounter).

Whatever we do with this check, it should be ensured that it still 
triggers on gcc.dg/pr45415.c at revision r163821.  IIRC to find the cause 
for this bug caused some more gray hair on my part :)


Ciao,
Michael.

      reply	other threads:[~2011-10-14 14:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-13 13:52 Jakub Jelinek
2011-10-14  9:37 ` Richard Guenther
2011-10-14 14:26   ` Michael Matz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.1110141558430.20082@wotan.suse.de \
    --to=matz@suse.de \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@redhat.com \
    --cc=pinskia@gmail.com \
    --cc=rguenther@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).