From: "Joseph S. Myers" <joseph@codesourcery.com>
To: "Ludovic Courtès" <ludovic.courtes@inria.fr>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Don't insert white space in 'orig_option_with_args_text' for OPT_l
Date: Fri, 09 Mar 2012 17:28:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.64.1203091723210.12881@digraph.polyomino.org.uk> (raw)
In-Reply-To: <87ipidvl7h.fsf@inria.fr>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: TEXT/PLAIN; charset=X-UNKNOWN, Size: 705 bytes --]
On Fri, 9 Mar 2012, Ludovic Courtès wrote:
> * gcc/opts-common.c (generate_option): Don't insert white space in
> `canonical_option' when OPT_INDEX is OPT_l.
No, opts-common.c should not have special cases for individual options
like that. The canonical form has the separate arguments. gcc.c has a
special case for how it passes this option to subprocesses; if you have
problems with some output from gfortran involving -l options, you should
change the gfortran driver as needed so it outputs -l options in a
different way.
Your subject refers to orig_option_with_args_text while your ChangeLog
entry refers to canonical_option.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2012-03-09 17:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-09 15:38 [PATCH] Don’t insert white space in ‘orig_option_with_args_text’ " Ludovic Courtès
2012-03-09 17:28 ` Joseph S. Myers [this message]
2012-03-12 11:02 ` [PATCH] Don't insert white space in 'orig_option_with_args_text' " Ludovic Courtès
2012-03-12 12:41 ` Joseph S. Myers
2012-03-13 10:12 ` Ludovic Courtès
2012-03-29 8:38 ` [PATCH, ping #1] " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1203091723210.12881@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=ludovic.courtes@inria.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).