From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-315448-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 3592 invoked by alias); 22 Mar 2012 14:12:48 -0000
Received: (qmail 3582 invoked by uid 22791); 22 Mar 2012 14:12:47 -0000
X-SWARE-Spam-Status: No, hits=-5.6 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from cantor2.suse.de (HELO mx2.suse.de) (195.135.220.15)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 22 Mar 2012 14:12:34 +0000
Received: from relay1.suse.de (unknown [195.135.220.254])	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))	(No client certificate requested)	by mx2.suse.de (Postfix) with ESMTP id 2EFDF90B96;	Thu, 22 Mar 2012 15:12:33 +0100 (CET)
Date: Thu, 22 Mar 2012 14:12:00 -0000
From: Michael Matz <matz@suse.de>
To: Mike Stump <mikestump@comcast.net>
Cc: Richard Sandiford <rdsandiford@googlemail.com>,	gcc-patches Patches <gcc-patches@gcc.gnu.org>
Subject: Re: remove wrong code in immed_double_const
In-Reply-To: <DF6339D4-BFF6-45FA-A5E0-8141F0BD4199@comcast.net>
Message-ID: <Pine.LNX.4.64.1203221444100.25409@wotan.suse.de>
References: <5FF5A724-3FE1-4E97-8124-542A0B8259FE@comcast.net> <87obrvd6fh.fsf@talisman.home> <C52AA600-299B-4E1F-9855-D1612FF2EC0B@comcast.net> <87haxmgqoo.fsf@talisman.home> <7C6A7462-C1D3-4765-83FF-3B3C726D92E5@comcast.net> <8762e09sgc.fsf@talisman.home> <0A5CBD0C-FC94-4637-B230-1A83372DE91A@comcast.net> <CAFiYyc1Yn8nvfqxwYQKhoBATG=QJg+tvWRK2aa1LTdY3+oHSkw@mail.gmail.com> <g44ntjh7hx.fsf@richards-thinkpad.stglab.manchester.uk.ibm.com> <CAFiYyc0dSZU5ZfSxHRc493rs1jeXY1PTdi=QHCoMtKgZnTdRvA@mail.gmail.com> <g4zkbbfofy.fsf@richards-thinkpad.stglab.manchester.uk.ibm.com> <B5BB677F-55F7-41F3-92A6-60B1D9577426@comcast.net> <g4obrqf5zm.fsf@richards-thinkpad.stglab.manchester.uk.ibm.com> <DF6339D4-BFF6-45FA-A5E0-8141F0BD4199@comcast.net>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-IsSubscribed: yes
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2012-03/txt/msg01507.txt.bz2

Hi,

On Wed, 21 Mar 2012, Mike Stump wrote:

> --- a/gcc/emit-rtl.c
> +++ b/gcc/emit-rtl.c
> @@ -531,10 +531,9 @@ immed_double_const (HOST_WIDE_INT i0, HOST_WIDE_INT i1, enum machine_mode mode)
>  
>       1) If GET_MODE_BITSIZE (mode) <= HOST_BITS_PER_WIDE_INT, then we use
>  	gen_int_mode.
> -     2) GET_MODE_BITSIZE (mode) == 2 * HOST_BITS_PER_WIDE_INT, but the value of
> -	the integer fits into HOST_WIDE_INT anyway (i.e., i1 consists only
> -	from copies of the sign bit, and sign of i0 and i1 are the same),  then
> -	we return a CONST_INT for i0.
> +     2) If the value of the integer fits into HOST_WIDE_INT anyway
> +        (i.e., i1 consists only from copies of the sign bit, and sign
> +	of i0 and i1 are the same), then we return a CONST_INT for i0.

I see that you didn't remove the assert as part of this patch.  I'd like 
to see what you like to do to this routine once the rest goes in.  In 
particular I don't think just removing the assert will be enough, at the 
very least the block comment should be saying something about what the 
routine exactly does (or doesn't do) for modes where the two HWI arguments 
can't specify all bits.

My point is, for large modes i0 and i1 will only specify the low 2*HWIbits 
bits.  Something needs to document what the upper bits will be (be they 
implicit or explicit), otherwise people reading the comment will always 
wonder what exactly is supposed to happen.  I'm not 100% sure what it 
should say, though.  Probably the interpretation of the upper bits depends 
on the users of the so generated CONST_DOUBLEs.


Ciao,
Michael.