From: "Joseph S. Myers" <joseph@codesourcery.com>
To: Christophe Lyon <christophe.lyon@linaro.org>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [ARM] Turning off 64bits ops in Neon and gfortran/modulo-scheduling problem
Date: Thu, 29 Nov 2012 21:12:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.64.1211292057530.27729@digraph.polyomino.org.uk> (raw)
In-Reply-To: <CAKdteOafeC0sn5rTkVykkBqefd3rM4pvSRqdHgZmaUuZ8Ts=YA@mail.gmail.com>
On Thu, 29 Nov 2012, Christophe Lyon wrote:
> 2012-11-28 Christophe Lyon <christophe.lyon@linaro.org>
>
> gcc/
> * config/arm/arm-protos.h (tune_params): Add
> prefer_neon_for_64bits field.
> * config/arm/arm.c (prefer_neon_for_64bits): New variable.
> (arm_slowmul_tune): Default prefer_neon_for_64bits to false.
> (arm_fastmul_tune, arm_strongarm_tune, arm_xscale_tune): Ditto.
> (arm_9e_tune, arm_v6t2_tune, arm_cortex_tune): Ditto.
> (arm_cortex_a5_tune, arm_cortex_a15_tune): Ditto.
> (arm_cortex_a9_tune, arm_fa726te_tune): Ditto.
> (arm_option_override): Handle -mneon-for-64bits new option.
> * config/arm/arm.h (TARGET_PREFER_NEON_64BITS): New macro.
> (prefer_neon_for_64bits): Declare new variable.
> * config/arm/arm.md (arch): Rename neon_onlya8 and neon_nota8 to
> avoid_neon_for_64bits and neon_for_64bits.
> (arch_enabled): Handle new arch types.
> (one_cmpldi2): Use new arch names.
> * config/arm/neon.md (adddi3_neon, subdi3_neon, iordi3_neon)
> (anddi3_neon, xordi3_neon, ashldi3_neon, <shift>di3_neon): Use
> neon_for_64bits instead of nota8 and avoid_neon_for_64bits instead
> of onlya8.
This ChangeLog entry doesn't appear to mention the arm.opt change.
Furthermore, the patch seems to be missing any .texi change to document
the option; any new option needs documentation. You are also missing
testcases for the testsuite to verify that both enabled and disabled
states of the option work properly.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2012-11-29 20:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-29 17:16 Christophe Lyon
2012-11-29 21:12 ` Joseph S. Myers [this message]
2012-11-30 16:38 ` Christophe Lyon
2012-12-07 8:35 ` Christophe Lyon
2012-12-14 16:58 ` Christophe Lyon
2012-12-17 15:12 ` Richard Earnshaw
2012-12-19 16:00 ` Christophe Lyon
2013-01-08 16:24 ` Christophe Lyon
2013-01-16 13:46 ` Christophe Lyon
2013-01-21 16:53 ` Christophe Lyon
2013-02-01 17:43 ` Ramana Radhakrishnan
2013-03-21 14:42 ` Christophe Lyon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1211292057530.27729@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=christophe.lyon@linaro.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).