From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17834 invoked by alias); 29 Nov 2012 20:59:49 -0000 Received: (qmail 17819 invoked by uid 22791); 29 Nov 2012 20:59:47 -0000 X-SWARE-Spam-Status: No, hits=-4.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 29 Nov 2012 20:59:42 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1TeBCu-0003YQ-QP from joseph_myers@mentor.com ; Thu, 29 Nov 2012 12:59:40 -0800 Received: from SVR-IES-FEM-02.mgc.mentorg.com ([137.202.0.106]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Thu, 29 Nov 2012 12:59:40 -0800 Received: from digraph.polyomino.org.uk (137.202.0.76) by SVR-IES-FEM-02.mgc.mentorg.com (137.202.0.106) with Microsoft SMTP Server id 14.1.289.1; Thu, 29 Nov 2012 20:59:39 +0000 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.76) (envelope-from ) id 1TeBCr-0007Xb-Tu; Thu, 29 Nov 2012 20:59:38 +0000 Date: Thu, 29 Nov 2012 21:12:00 -0000 From: "Joseph S. Myers" To: Christophe Lyon CC: "gcc-patches@gcc.gnu.org" Subject: Re: [ARM] Turning off 64bits ops in Neon and gfortran/modulo-scheduling problem In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-11/txt/msg02502.txt.bz2 On Thu, 29 Nov 2012, Christophe Lyon wrote: > 2012-11-28 Christophe Lyon > > gcc/ > * config/arm/arm-protos.h (tune_params): Add > prefer_neon_for_64bits field. > * config/arm/arm.c (prefer_neon_for_64bits): New variable. > (arm_slowmul_tune): Default prefer_neon_for_64bits to false. > (arm_fastmul_tune, arm_strongarm_tune, arm_xscale_tune): Ditto. > (arm_9e_tune, arm_v6t2_tune, arm_cortex_tune): Ditto. > (arm_cortex_a5_tune, arm_cortex_a15_tune): Ditto. > (arm_cortex_a9_tune, arm_fa726te_tune): Ditto. > (arm_option_override): Handle -mneon-for-64bits new option. > * config/arm/arm.h (TARGET_PREFER_NEON_64BITS): New macro. > (prefer_neon_for_64bits): Declare new variable. > * config/arm/arm.md (arch): Rename neon_onlya8 and neon_nota8 to > avoid_neon_for_64bits and neon_for_64bits. > (arch_enabled): Handle new arch types. > (one_cmpldi2): Use new arch names. > * config/arm/neon.md (adddi3_neon, subdi3_neon, iordi3_neon) > (anddi3_neon, xordi3_neon, ashldi3_neon, di3_neon): Use > neon_for_64bits instead of nota8 and avoid_neon_for_64bits instead > of onlya8. This ChangeLog entry doesn't appear to mention the arm.opt change. Furthermore, the patch seems to be missing any .texi change to document the option; any new option needs documentation. You are also missing testcases for the testsuite to verify that both enabled and disabled states of the option work properly. -- Joseph S. Myers joseph@codesourcery.com