From: "Joseph S. Myers" <joseph@codesourcery.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: <gcc-patches@gcc.gnu.org>
Subject: Re: PING^2: [PATCH] Support -fuse-ld=bfd and -fuse-ld=gold
Date: Wed, 19 Dec 2012 21:13:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.64.1212192110300.5839@digraph.polyomino.org.uk> (raw)
In-Reply-To: <CAMe9rOoVQZJRE5buG19YDko++NZttkTWxcNNXFz07D8mVvmoLA@mail.gmail.com>
On Thu, 13 Dec 2012, H.J. Lu wrote:
> Hi Joseph,
>
> Can you review this?
I'm still confused as to what's supposed to be reviewed and whether the
issues raised in the previous discussions have been properly addressed.
Looking at <http://gcc.gnu.org/ml/gcc-patches/2012-12/msg00484.html>, I
don't see the need for the variables named with Var in common.opt, and I'd
think proper help text would be better than using Undocumented.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2012-12-19 21:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-13 16:47 H.J. Lu
2012-12-19 21:13 ` Joseph S. Myers [this message]
2012-12-19 22:20 ` H.J. Lu
2013-01-07 16:07 ` Joseph S. Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1212192110300.5839@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).