From: "Joseph S. Myers" <joseph@codesourcery.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Jason Merrill <jason@redhat.com>, <gcc-patches@gcc.gnu.org>
Subject: Re: [C/C++ PATCH] shift with negative or too big count warning (PR c/48418)
Date: Tue, 08 Jan 2013 22:33:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.64.1301082231060.11486@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20130108200403.GN7269@tucnak.redhat.com>
On Tue, 8 Jan 2013, Jakub Jelinek wrote:
> Hi!
>
> As discussed in the PR, on the following testcase we've regressed with the
> introduction of c_fully_fold, when the C FE normally warns the argument
> isn't folded yet. Fixed by also warning in c_fully_fold_internal, if before
> that function the shift count wasn't INTEGER_CST and after it it is.
>
> The testcase also revealed a regression on the C++ FE side, caused by
> SIZEOF_EXPR folding deferral.
>
> Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?
The C front-end changes are OK. Properly diagnostic messages inside ? :
conditionals should be marked up with G_() to ensure that both cases are
extracted for translation, though in this case it doesn't matter much
given that the message wording should stay identical to other copies of
the same messages.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2013-01-08 22:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-08 20:04 Jakub Jelinek
2013-01-08 22:33 ` Joseph S. Myers [this message]
2013-01-09 14:45 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1301082231060.11486@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=jason@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).