From: "Joseph S. Myers" <joseph@codesourcery.com>
To: "Iyer, Balaji V" <balaji.v.iyer@intel.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Jakub Jelinek <jakub@redhat.com>,
"mpolacek@gcc.gnu.org" <mpolacek@gcc.gnu.org>
Subject: RE: [PATCH] Fix for PR c/57563
Date: Mon, 10 Jun 2013 21:18:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.64.1306102116100.13702@digraph.polyomino.org.uk> (raw)
In-Reply-To: <BF230D13CA30DD48930C31D4099330003A42D776@FMSMSX101.amr.corp.intel.com>
On Mon, 10 Jun 2013, Iyer, Balaji V wrote:
> I looked into it a bit more detail. It was an error on my side. I was
> removing the excess precision expr layer instead of fully folding it. I
> did that change (i.e. fully fold the expression) and all the errors seem
> to go away. Here is the fixed patch that fixes PR c/57563. It passes for
> 32 bit and 64 bit tests. Here are the changelog entries:
This version is better, but if removing an EXCESS_PRECISION_EXPR there
caused problems, why is it OK to remove CONVERT_EXPR and NOP_EXPR like you
still do - won't that also cause type mismatches (at least if the
conversions are to types that count as sufficiently different for GIMPLE
purposes - say conversions between 32-bit and 64-bit integers)? Maybe you
actually need to fold without removing any such wrappers first at all?
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2013-06-10 21:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-09 1:20 Iyer, Balaji V
2013-06-10 14:39 ` Joseph S. Myers
2013-06-10 15:08 ` Iyer, Balaji V
2013-06-10 15:16 ` Joseph S. Myers
2013-06-10 17:19 ` Iyer, Balaji V
2013-06-10 21:18 ` Joseph S. Myers [this message]
2013-06-10 22:16 ` Iyer, Balaji V
2013-06-10 22:45 ` Joseph S. Myers
2013-06-10 22:18 ` FW: " Iyer, Balaji V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1306102116100.13702@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=balaji.v.iyer@intel.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=mpolacek@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).