From: "Joseph S. Myers" <joseph@codesourcery.com>
To: Matthias Klose <doko@ubuntu.com>
Cc: "GCC Patches" <gcc-patches@gcc.gnu.org>,
"Manuel López-Ibáñez" <lopezibanez@gmail.com>
Subject: Re: [patch] fix impliedness of -Wunused-parameter depending on -Wexta option ordering
Date: Mon, 12 May 2014 17:30:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.64.1405121726110.371@digraph.polyomino.org.uk> (raw)
In-Reply-To: <5370F366.80300@ubuntu.com>
On Mon, 12 May 2014, Matthias Klose wrote:
> I didn't look close enough to the gfortran test results. PR driver/61126 is a
> fix for the regression introduced with the fix for the above issue. With this
> patch proposed by Manuel, gfortran.dg/wextra_1.f now passes, and no new
> regressions seen on the trunk and the branches.
I think changing the order of the handlers has far too high a risk of
introducing further nonobvious regressions to consider it for the
branches. You need a clear and careful analysis of the circumstances
under which the order of the handlers can affect observable compiler
behavior in order to justify such a change as safe. But I think a better
principle is that if the order matters, there is a bug in those handlers
and they should be fixed so that the order doesn't matter (absent a clear
design showing why it is desirable for the order to matter).
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2014-05-12 17:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-08 21:20 Matthias Klose
2014-05-08 21:37 ` Joseph S. Myers
2014-05-12 16:14 ` Matthias Klose
2014-05-12 17:30 ` Joseph S. Myers [this message]
2014-05-12 19:27 ` Manuel López-Ibáñez
2014-05-12 20:24 ` Joseph S. Myers
2014-05-14 14:15 ` Manuel López-Ibáñez
2014-05-14 21:35 ` Joseph S. Myers
2014-05-14 16:43 ` Matthias Klose
2014-05-09 14:41 Dominique Dhumieres
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1405121726110.371@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=doko@ubuntu.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=lopezibanez@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).