From: "Joseph S. Myers" <joseph@codesourcery.com>
To: Sylvestre Ledru <sylvestre@debian.org>
Cc: Jason Merrill <jason@redhat.com>, <gcc-patches@gcc.gnu.org>
Subject: Re: [Patch] PR55189 enable -Wreturn-type by default
Date: Wed, 04 Jun 2014 23:31:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.64.1406042321130.2874@digraph.polyomino.org.uk> (raw)
In-Reply-To: <538F7856.1090104@debian.org>
On Wed, 4 Jun 2014, Sylvestre Ledru wrote:
> Hello,
>
> Finally, I have been able to update all tests with -Wreturn-type enabled
> by default. AFAIK, under GNU/Linux Debian Jessie 64 bits, there is no
> PASS->FAIL tests.
>
> Now, I would like to know if I can commit that into the repository. Who
> can review that?
>
> As attachment, you will find the actual (tiny) patch.
>
> I split the tests update by languages. As they are big ( 1260 files
> changed, 1638 insertions(+), 903 deletions(-) ), I uploaded the patches
> on my server:
Some of those patches appear to be addressing cases where control appears
to reach the end of a function returning non-void, as opposed to cases
where the return type defaults to int. As I said in
<https://gcc.gnu.org/ml/gcc/2014-01/msg00207.html>, I don't think that
warning is appropriate to enable by default as it catches perfectly valid
C90 / C99 code that avoids using extensions to annotate noreturn
functions.
(I *do* think it's appropriate to enable by default the warning about
return type defaulting to int - more generally, to enable -Wimplicit-int
-Wimplicit-function-declaration - and the -Wreturn-type warning about a
return statement without a value in a function returning non-void also
seems appropriate to enable by default. Warning about the absence of any
return statement in a function returning non-void is probably also a
reasonable default warning from the -Wreturn-type set; it's specifically
the flow-based warnings that can give false positives in the absence of
noreturn annotations that I'm dubious about enabling by default.)
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2014-06-04 23:31 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 19:49 Sylvestre Ledru
2014-06-04 22:35 ` Mike Stump
2014-06-04 23:31 ` Joseph S. Myers [this message]
2014-06-05 9:33 ` Sylvestre Ledru
2014-06-05 18:01 ` Joseph S. Myers
2014-06-17 16:52 ` Sylvestre Ledru
2014-06-17 17:15 ` Joseph S. Myers
2014-06-17 17:37 ` Sylvestre Ledru
2014-06-17 17:41 ` Joseph S. Myers
2014-07-07 17:18 ` Sylvestre Ledru
2014-07-20 19:20 ` Sylvestre Ledru
2014-07-30 22:10 ` Joseph S. Myers
2014-08-11 7:44 ` Sylvestre Ledru
2014-08-12 17:49 ` Joseph S. Myers
2014-08-12 17:53 ` Sylvestre Ledru
2014-08-14 17:01 ` Sylvestre Ledru
-- strict thread matches above, loose matches on Subject: below --
2014-08-14 18:49 Manuel López-Ibáñez
2014-08-15 16:28 ` Sylvestre Ledru
2014-08-19 22:03 ` Joseph S. Myers
2014-08-20 21:42 ` Sylvestre Ledru
2014-08-20 21:58 ` Joseph S. Myers
2013-12-20 17:54 Sylvestre Ledru
2013-12-27 5:26 ` Chung-Ju Wu
2013-12-27 5:32 ` Yury Gribov
2014-01-14 17:49 ` Sylvestre Ledru
2014-01-16 19:44 ` Jason Merrill
2014-01-23 6:44 ` Sylvestre Ledru
2014-01-23 18:48 ` Jason Merrill
2014-01-23 18:57 ` Sylvestre Ledru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1406042321130.2874@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
--cc=sylvestre@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).