From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12381 invoked by alias); 17 Jun 2014 17:41:32 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 12369 invoked by uid 89); 17 Jun 2014 17:41:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 Jun 2014 17:41:31 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1WwxNv-0003pk-01 from joseph_myers@mentor.com ; Tue, 17 Jun 2014 10:41:27 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Tue, 17 Jun 2014 10:41:26 -0700 Received: from digraph.polyomino.org.uk (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.2.247.3; Tue, 17 Jun 2014 18:41:25 +0100 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.76) (envelope-from ) id 1WwxNr-0005Sp-V4; Tue, 17 Jun 2014 17:41:24 +0000 Date: Tue, 17 Jun 2014 17:41:00 -0000 From: "Joseph S. Myers" To: Sylvestre Ledru CC: , Jason Merrill Subject: Re: [Patch] PR55189 enable -Wreturn-type by default In-Reply-To: <53A07CCC.2030004@debian.org> Message-ID: References: <538F7856.1090104@debian.org> <53903961.9030501@debian.org> <53A07226.4040803@debian.org> <53A07CCC.2030004@debian.org> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-SW-Source: 2014-06/txt/msg01370.txt.bz2 On Tue, 17 Jun 2014, Sylvestre Ledru wrote: > OK. I will do that. > We should test the following: > * default => run just -Wreturn-type > * -Wreturn-type => Run both > * -Wreturn-type + -Wmissing-return => Run both > * -Wno-return-type + -Wmissing-return => Run just the second one > * -Wno-return-type + -Wno-missing-return => Run none > Do you see any other? That looks like the right things to test, if there are no changes for anything other than those options. > Besides that, are you OK with my changes? (with the tests updated) The tests are key to reviewing whether the code changes actually do the right thing. -- Joseph S. Myers joseph@codesourcery.com