From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18646 invoked by alias); 1 Sep 2014 21:47:21 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 18617 invoked by uid 89); 1 Sep 2014 21:47:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 01 Sep 2014 21:47:18 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-FEM-01.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1XOZRQ-0000lP-Te from joseph_myers@mentor.com ; Mon, 01 Sep 2014 14:47:13 -0700 Received: from digraph.polyomino.org.uk (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.2.247.3; Mon, 1 Sep 2014 22:47:11 +0100 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.82) (envelope-from ) id 1XOZRO-0003uu-Pu; Mon, 01 Sep 2014 21:47:10 +0000 Date: Mon, 01 Sep 2014 21:47:00 -0000 From: "Joseph S. Myers" To: DJ Delorie CC: , Subject: Re: __intN patch 3/5: main __int128 -> __intN conversion. In-Reply-To: <201408260303.s7Q33nqm024601@greed.delorie.com> Message-ID: References: <201408132211.s7DMBGBu016387@greed.delorie.com> <201408212123.s7LLNPIQ018746@greed.delorie.com> <201408220515.s7M5Fhpa007479@greed.delorie.com> <201408221924.s7MJOcjB022631@greed.delorie.com> <201408260303.s7Q33nqm024601@greed.delorie.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-SW-Source: 2014-09/txt/msg00076.txt.bz2 On Mon, 25 Aug 2014, DJ Delorie wrote: > + for (i = 0; i < NUM_INT_N_ENTS; i ++) > + if (int_n_enabled_p[i]) > + { > + char buf[35+20+20]; > + > + /* These are used to configure the C++ library. */ > + > + if (!flag_iso || int_n_data[i].bitsize == POINTER_SIZE) > + { > + sprintf (buf, "__GLIBCXX_TYPE_INT_N_%d=__int%d", i, int_n_data[i].bitsize); > + cpp_define (parse_in, buf); > + > + sprintf (buf, "__GLIBCXX_BITSIZE_INT_N_%d=%d", i, int_n_data[i].bitsize); > + cpp_define (parse_in, buf); > + } > + } I think this should at least initially be conditioned on c_dialect_cxx (). > + case RID_INT_N_0: > + case RID_INT_N_1: > + case RID_INT_N_2: > + case RID_INT_N_3: > + specs->int_n_idx = i - RID_INT_N_0; > + if (!in_system_header_at (input_location) > + /* As a special exception, allow a type that's used > + for __SIZE_TYPE__. */ > + && int_n_data[specs->int_n_idx].bitsize != POINTER_SIZE) Given the precedent for long long as __SIZE_TYPE__, I don't think we should have that special exception. The non-C++/libstdc++ parts are OK with those changes. -- Joseph S. Myers joseph@codesourcery.com