From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21946 invoked by alias); 16 Sep 2014 21:12:59 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 21930 invoked by uid 89); 16 Sep 2014 21:12:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 16 Sep 2014 21:12:57 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-FEM-01.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1XU03R-0006mP-KE from joseph_myers@mentor.com ; Tue, 16 Sep 2014 14:12:53 -0700 Received: from digraph.polyomino.org.uk (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.3.181.6; Tue, 16 Sep 2014 22:12:52 +0100 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.82) (envelope-from ) id 1XU03P-0002ga-6N; Tue, 16 Sep 2014 21:12:51 +0000 Date: Tue, 16 Sep 2014 21:12:00 -0000 From: "Joseph S. Myers" To: Andrew MacLeod CC: gcc-patches Subject: Re: Flatten function.h In-Reply-To: <54188D7E.4090701@redhat.com> Message-ID: References: <54188D7E.4090701@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-SW-Source: 2014-09/txt/msg01316.txt.bz2 On Tue, 16 Sep 2014, Andrew MacLeod wrote: > I did an include file reduction on all the language/*.[ch] and core *.[ch] > files, but left the target files with the full complement of 7 includes that > function.h use to have. Its probably easier when this is all done to fully > reduce the targets one at a time... there are so many nooks and crannies I > figured I'd bust something right now if i tried to do all the targets as well > :-) How did you determine what includes to remove? You appear to have removed tm.h includes from various files that do in fact use target macros; maybe they get it indirectly included by some other header, but I thought a principle of this flattening was to avoid relying on such indirect inclusions. Because of possible use of target macros in #ifdef conditionals, "compiles with the include removed" is not a sufficient condition for removing it. cfgrtl.c gimple-fold.c mode-switching.c tree-inline.c vmsdbgout.c fortran/f95-lang.c fortran/trans-decl.c objc/objc-act.c -- Joseph S. Myers joseph@codesourcery.com