From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26080 invoked by alias); 13 Aug 2007 17:56:36 -0000 Received: (qmail 25885 invoked by uid 22791); 13 Aug 2007 17:56:35 -0000 X-Spam-Check-By: sourceware.org Received: from pollux.ds.pg.gda.pl (HELO pollux.ds.pg.gda.pl) (153.19.208.7) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 13 Aug 2007 17:56:26 +0000 Received: from localhost (localhost [127.0.0.1]) by pollux.ds.pg.gda.pl (Postfix) with ESMTP id DABB3E2409; Mon, 13 Aug 2007 19:56:15 +0200 (CEST) Received: from pollux.ds.pg.gda.pl ([127.0.0.1]) by localhost (pollux.ds.pg.gda.pl [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dzCENc4h6+lT; Mon, 13 Aug 2007 19:56:15 +0200 (CEST) Received: from piorun.ds.pg.gda.pl (piorun.ds.pg.gda.pl [153.19.208.8]) by pollux.ds.pg.gda.pl (Postfix) with ESMTP id 71C23E1F30; Mon, 13 Aug 2007 19:56:15 +0200 (CEST) Received: from blysk.ds.pg.gda.pl (macro@blysk.ds.pg.gda.pl [153.19.208.6]) by piorun.ds.pg.gda.pl (8.13.8/8.13.8) with ESMTP id l7DHuPxt027838; Mon, 13 Aug 2007 19:56:25 +0200 Date: Mon, 13 Aug 2007 17:56:00 -0000 From: "Maciej W. Rozycki" To: David Daney cc: Richard Sandiford , GCJ-patches , GCC Patches Subject: Re: [Patch] libffi: Add MIPS64 support. In-Reply-To: <46BD4BDE.8030407@avtrex.com> Message-ID: References: <46BA9F13.2090003@avtrex.com> <87r6mddo7z.fsf@firetop.home> <46BB3754.30105@avtrex.com> <87wsw4d7h4.fsf@firetop.home> <46BB4F54.108@avtrex.com> <46BC8300.4080407@avtrex.com> <46BD4BDE.8030407@avtrex.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Virus-Status: Clean X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2007-08/txt/msg00812.txt.bz2 David, While integrating into 4.1.2 I had a brief look over your patch again over the weekend and I have got two minor points: 1. You use "unsigned" rather than "unsigned int", which makes your code look a little bit too K&Rish. 2. Given the coverage FFI_MIPS_N32 should probably be renamed to FFI_MIPS_NEWABI as it is now somewhat confusing. And last but not least, with your changes there is now no difference between Linux and IRIX anymore, so it may be worth unifying the MIPS target like the others; it seems to be the only oddball. 2007-08-13 Maciej W. Rozycki * Makefile.am: Unify MIPS_IRIX and MIPS_LINUX into MIPS. * configure.ac: Likewise. * Makefile.in: Regenerate. * configure: Regenerate. OK to apply? Maciej gcc-4.3.0-20070813-mips64-linux-libffi.patch diff -up --recursive --new-file gcc-4.3.0-20070813.macro/libffi/Makefile.am gcc-4.3.0-20070813/libffi/Makefile.am --- gcc-4.3.0-20070813.macro/libffi/Makefile.am 2007-08-11 06:55:52.000000000 +0000 +++ gcc-4.3.0-20070813/libffi/Makefile.am 2007-08-13 16:52:18.000000000 +0000 @@ -84,10 +84,7 @@ libffi_la_SOURCES = src/debug.c src/prep nodist_libffi_la_SOURCES = -if MIPS_IRIX -nodist_libffi_la_SOURCES += src/mips/ffi.c src/mips/o32.S src/mips/n32.S -endif -if MIPS_LINUX +if MIPS nodist_libffi_la_SOURCES += src/mips/ffi.c src/mips/o32.S src/mips/n32.S endif if X86 diff -up --recursive --new-file gcc-4.3.0-20070813.macro/libffi/configure.ac gcc-4.3.0-20070813/libffi/configure.ac --- gcc-4.3.0-20070813.macro/libffi/configure.ac 2007-08-11 06:55:52.000000000 +0000 +++ gcc-4.3.0-20070813/libffi/configure.ac 2007-08-13 16:53:00.000000000 +0000 @@ -95,10 +95,10 @@ case "$host" in ;; mips-sgi-irix5.* | mips-sgi-irix6.*) - TARGET=MIPS_IRIX; TARGETDIR=mips + TARGET=MIPS; TARGETDIR=mips ;; mips*-*-linux*) - TARGET=MIPS_LINUX; TARGETDIR=mips + TARGET=MIPS; TARGETDIR=mips ;; powerpc*-*-linux* | powerpc-*-sysv*) @@ -151,8 +151,7 @@ if test $TARGETDIR = unknown; then AC_MSG_ERROR(["libffi has not been ported to $host."]) fi -AM_CONDITIONAL(MIPS_IRIX, test x$TARGET = xMIPS_IRIX) -AM_CONDITIONAL(MIPS_LINUX, test x$TARGET = xMIPS_LINUX) +AM_CONDITIONAL(MIPS, test x$TARGET = xMIPS) AM_CONDITIONAL(SPARC, test x$TARGET = xSPARC) AM_CONDITIONAL(X86, test x$TARGET = xX86) AM_CONDITIONAL(X86_WIN32, test x$TARGET = xX86_WIN32) @@ -176,11 +175,6 @@ AM_CONDITIONAL(PA_LINUX, test x$TARGET = AM_CONDITIONAL(PA_HPUX, test x$TARGET = xPA_HPUX) AM_CONDITIONAL(PA64_HPUX, test x$TARGET = xPA64_HPUX) -case x$TARGET in - xMIPS*) TARGET=MIPS ;; - *) ;; -esac - AC_HEADER_STDC AC_CHECK_FUNCS(memcpy) AC_FUNC_ALLOCA