public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Krister Walfridsson <krister.walfridsson@gmail.com>
To: gcc-patches@gcc.gnu.org
Subject: [committed] Fix NetBSD libgomp bootstrap error.
Date: Sun, 29 Jun 2008 21:55:00 -0000	[thread overview]
Message-ID: <Pine.NEB.4.64.0806292341200.8386@pc20.kwa> (raw)

[-- Attachment #1: Type: TEXT/PLAIN, Size: 672 bytes --]

libgomp breaks bootstrap on NetBSD because of
   cc1: warnings being treated as errors
   ../../../gcc/libgomp/env.c: In function 'parse_stacksize':
   ../../../gcc/libgomp/env.c:207: error: array subscript has type 'char'
   ../../../gcc/libgomp/env.c: In function 'parse_spincount':
   ../../../gcc/libgomp/env.c:276: error: array subscript has type 'char'

I have committed the attached patch under the obvious rule.

Bootstrapped and tested on x86_64-unknown-netbsd4.0 and
i386-unknown-netbsdelf3.1.

    /Krister


2008-06-29  Krister Walfridsson  <krister.walfridsson@gmail.com>

 	* env.c (parse_stacksize): Add cast to avoid warning.
 	(parse_spincount): Likewise.

[-- Attachment #2: Type: TEXT/PLAIN, Size: 604 bytes --]

Index: libgomp/env.c
===================================================================
--- libgomp/env.c	(revision 137259)
+++ libgomp/env.c	(working copy)
@@ -207,7 +207,7 @@ parse_stacksize (const char *name, unsig
     ++end;
   if (*end != '\0')
     {
-      switch (tolower (*end))
+      switch (tolower ((unsigned char) *end))
 	{
 	case 'b':
 	  shift = 0;
@@ -276,7 +276,7 @@ parse_spincount (const char *name, unsig
     ++end;
   if (*end != '\0')
     {
-      switch (tolower (*end))
+      switch (tolower ((unsigned char) *end))
 	{
 	case 'k':
 	  mult = 1000LL;

                 reply	other threads:[~2008-06-29 21:43 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.NEB.4.64.0806292341200.8386@pc20.kwa \
    --to=krister.walfridsson@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).