public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Benjamin Kosnik <bkoz@redhat.com>
To: Mark Mitchell <mark@codesourcery.com>
Cc: Franz Sirl <Franz.Sirl-kernel@lauterbach.com>,
	Gabriel Dos Reis <gdr@codesourcery.com>,
	"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
	"libstdc++@gcc.gnu.org" <libstdc++@gcc.gnu.org>
Subject: Re: V3 PATCH: Fix PR3988
Date: Tue, 14 Aug 2001 16:03:00 -0000	[thread overview]
Message-ID: <Pine.SOL.3.91.1010814155846.19791A@taarna.cygnus.com> (raw)
In-Reply-To: <297580000.997827294@warlock.codesourcery.com>

> > Well, a patch for config/os/gnu-linux/bits/os_defines.h or a solution
> > like  the 386 one that Mark did?

Please try to keep this cpu-specific stuff out of os-specific headers. 

> I think the CPU-specific way is better, in general.  I think that David
> asked me about doing that way, originally, and I chickened out; either
> way does get the job done.

Only, putting the cpu-stuff in config/cpu actually makes sense. This 
avoids confusion, and makes future maintenance enjoyable.

> If most of the systems on PowerPC do this the same way, it makes
> sense to use the CPU-specific way.  I'd prefer not to change existing
> configurations, though, if we can help it; there's no need to introduce
> risk on AIX, for example, if things already work correctly there.

Please do this correctly on the trunk, at least.

-benjamin

  reply	other threads:[~2001-08-14 16:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-08-14 15:15 Mark Mitchell
2001-08-14 16:03 ` Benjamin Kosnik [this message]
  -- strict thread matches above, loose matches on Subject: below --
2001-08-14 14:59 Mark Mitchell
2001-08-13 15:24 Mark Mitchell
2001-08-14 14:46 ` Franz Sirl
     [not found] ` <200108142147.XAA20070@mayo.cmla.ens-cachan.fr>
2001-08-14 14:53   ` Gabriel Dos Reis
2001-08-14 14:59     ` Franz Sirl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.SOL.3.91.1010814155846.19791A@taarna.cygnus.com \
    --to=bkoz@redhat.com \
    --cc=Franz.Sirl-kernel@lauterbach.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gdr@codesourcery.com \
    --cc=libstdc++@gcc.gnu.org \
    --cc=mark@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).