From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by sourceware.org (Postfix) with ESMTPS id 13ECF3857360; Thu, 20 Oct 2022 01:44:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 13ECF3857360 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666230283; x=1697766283; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=ewTAywkFUdv8VqEDMnpRDjhFAwp99zNi+CnJ+FHrhDA=; b=RPQkzcInO49OPgcjCCaZ7wP9jlU000sb2UU/+21If5l6BTqu25n6htrA h8/x9RijHHV1puSNQux3hxspaUHAfT7q0E7xxA6mSV5/DIprgQg4KlwqV Tc+XMvytth/gHuBLtN1AjdriOUuVICJHJhEZMcYHOjmZwXhrMSF+/WW+M vPFHiaEhX+twvbKpN16yfvfTeRyLLWTMo5RjDnK4e3SsQLeHdQcCaBN7O OTHMXlvkcC1pHiWSy8qMh+Uk8pJzdOSI5G93GHobKNocJzWfEAAsaFJiZ itjLtwveSBxIwA4aEExFtxYHSOCThK/WgOXPAygWhHMECqEjZZiOqk0FU A==; X-IronPort-AV: E=McAfee;i="6500,9779,10505"; a="293972238" X-IronPort-AV: E=Sophos;i="5.95,196,1661842800"; d="scan'208";a="293972238" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2022 18:44:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10505"; a="958628121" X-IronPort-AV: E=Sophos;i="5.95,196,1661842800"; d="scan'208";a="958628121" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga005.fm.intel.com with ESMTP; 19 Oct 2022 18:44:23 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 19 Oct 2022 18:44:17 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 19 Oct 2022 18:44:17 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 19 Oct 2022 18:44:17 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.47) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 19 Oct 2022 18:44:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XBiPo3WQhs/8t9rRC2Nd29gn1d0JYbxX6RV4lzSC7Q20QwgaR/x7cgh6B/hpGYv1AR9+/Sbu5uGLpmKdDFLL/X5+7T1qc4pFGKbCFKo8ff/wnqDTpp3Gt5s+H7dBdWVxzTlVSJaRYeDlKbd9aLn+FLSmDTl5/34BKNje8S2eolqyI1wFYA+k/Zeo+eSQYE25oQCAC0RqbuGxTtVPOjYmoi8T6kA8fdg8euGcHOTwUrfN6Czu/h7/votJ89qvAJ5BxPkYk/AeQC/3s2FXRyUPEdj9dKugKuyBUaUj5U8pOet9w3IpJCCZLFhfmcUObk8xTE2Hbu/VzyR2HPFXqEFJxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IlPAmiolTGYmJrNm9xldsdaiDuHJ/dfOCg98zHVrLFY=; b=dpOE2fTEvz1H/EZnxlrre0EGO3VusGe68p7sQhhaFPAyY0NNukMvffI7QPT3Gev5+gQYRZfNxTLmhhz6Pa6I9XHid9OYQUFBMAjGqYau5jWKy5kq25Q+gU2GQhKcFqAsT0uxGd9OX94Q2n3PjlfZcw4DwK0ATbB3R4NlDXQDAPeyvdmObZ+WTbRzXLTOFg4aHZf1g5WXJMUmUifHa2w8vUmvcOB/F48AT91ZhLZJVSqECF+KVCPH/308VEQrx7EQuT8yAna5WwMPmyCwkHguZh0sm1f4ICIMvM6ulPoESUORnPScvys/hjVwC+SKlC9Lhrw2DgSHJs57cnNadfte6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA1PR11MB5946.namprd11.prod.outlook.com (2603:10b6:806:23a::9) by PH8PR11MB7093.namprd11.prod.outlook.com (2603:10b6:510:217::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.33; Thu, 20 Oct 2022 01:44:15 +0000 Received: from SA1PR11MB5946.namprd11.prod.outlook.com ([fe80::3580:2e13:aa4b:d98d]) by SA1PR11MB5946.namprd11.prod.outlook.com ([fe80::3580:2e13:aa4b:d98d%3]) with mapi id 15.20.5723.033; Thu, 20 Oct 2022 01:44:15 +0000 From: "Jiang, Haochen" To: Segher Boessenkool , Andrew Pinski CC: "gcc-patches@gcc.gnu.org" , "aoliva@gcc.gnu.org" , "richard.sandiford@arm.com" , "uweigand@de.ibm.com" , "linkw@gcc.gnu.org" , "gnu@amylaar.uk" , "dje.gcc@gmail.com" , "olegendo@gcc.gnu.org" , "claziss@synopsys.com" , "mfortune@gmail.com" , "davem@redhat.com" , "dave.anglin@bell.net" , "hubicka@ucw.cz" , "richard.earnshaw@arm.com" , "rguenther@suse.de" , "marcus.shawcroft@arm.com" , "ramana.radhakrishnan@arm.com" , "Liu, Hongtao" Subject: RE: [PATCH 1/2] Add a parameter for the builtin function of prefetch to align with LLVM Thread-Topic: [PATCH 1/2] Add a parameter for the builtin function of prefetch to align with LLVM Thread-Index: AQHY36iHla+IM3KeSkqbg3kXafqqFq4V/SwAgABDBYCAAEdR0A== Date: Thu, 20 Oct 2022 01:44:15 +0000 Message-ID: References: <20221014083406.8406-1-haochen.jiang@intel.com> <20221014083406.8406-2-haochen.jiang@intel.com> <20221019211421.GQ25951@gate.crashing.org> In-Reply-To: <20221019211421.GQ25951@gate.crashing.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.500.17 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA1PR11MB5946:EE_|PH8PR11MB7093:EE_ x-ms-office365-filtering-correlation-id: 46ee3aec-ea59-47b4-7840-08dab23c9899 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Zo5HjJjtnqZoMEgwp+jYNZUj0DUDsA3/8YxPf1UqPI1r8eTfqSTlS4kn6bQ6vfFjHtUa8iSf+qDpcTExtZ6rHjDC6vC60MSlqbPrI41itMELtxQCG/Khaojr+m08vL3zeF5GMxXmcAR+eQ6TgLtwR4NzTooJ3Q5uSaQ8HH8B1oWSx7gWSh1P+g/JzBvq0jAJCcTUuuSnxGPS/CVM4yRaNvHAu+B2HPX+lO1+pN4DZ0os0Nfq9LnqAzzSUHYpAJm087ZyoKaUQTzBmJig0Cj8q6vvIcNyQBLeSmCh/5/PBCFzVx1yA2s/K8CdPtE2+eh+z1MAbLiIPDe029fUf1jZguemjPmV9uSZ1yAWyzZTp8cz43XQiSHEOCNx7fCODdUWh78lb3pwZegCGvhmVnSpoeStP6vkDr5UV7HKmPtjXyeXODGGUM/XvHQgeXtxRJnlX4bKVOPu1+LANv8bUUk0DhNvsns+oIanQYb5Tqjay6QNjJ4WUjzMnl95Y2FALUeLmTb2J+FmiQmueIKsN6JIGpsl9c+8geFY2CL8DM75BqzKQvXZLuqGr7sWgqAnVoidIeizALl/PDNEblEi2FZZiNcwxtTZ0DRKLUwrVGPdjB5/HZuogwM38lVRirUONhJZmzXnCEL7SapZQHkJoz80Y2hkawfXbwlA2oKIJgExFuS1BaG9i+vEfQxEN06omKyWsOAs4+36n9AR5MxEAMeXPC/vm8EO01aP3EenXdYmdcn14CzDcSxJSqjrCqrlitW8lc1jjbk/ApUksy5U8DZIYA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR11MB5946.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(366004)(136003)(346002)(376002)(396003)(451199015)(71200400001)(478600001)(122000001)(38070700005)(55016003)(316002)(54906003)(52536014)(8936002)(7696005)(110136005)(5660300002)(86362001)(82960400001)(107886003)(6506007)(53546011)(2906002)(83380400001)(66446008)(38100700002)(186003)(33656002)(8676002)(4326008)(41300700001)(66946007)(9686003)(76116006)(66476007)(7416002)(66556008)(26005)(64756008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?m/6wenwXkFoLraeVVP0Iq9nX8TwDbgm3KGFn7BJHmCE1TyTq1+KGDnv1gpSo?= =?us-ascii?Q?f7Cr8rZeUK3mCipTvCS2Da9mgFwqEccHJO9cZpcHsPDIAsotQI+rqGruz6X6?= =?us-ascii?Q?ttpcZsb7fmV3bslFcz2s2NM6eiOjAeSwPSZ25sZQKjRzJy0xQHWxS3MREnHN?= =?us-ascii?Q?jqLgP/VwrQ8XlgNCkee4Tefhq5rkR7qOg0anM1ru+bK4EJTresNDZYx0PWwB?= =?us-ascii?Q?GPSukPevFR6y90f5rHp+Py6qusZQVLbSYn9bw1B+bYznUFWQU2SL4J3YxXEL?= =?us-ascii?Q?F2r3eLAOflVWYVVLVRm9ziI1eo8qtp+DC+jPTRKvJo5kZDvYLuY0iIOojmB7?= =?us-ascii?Q?lJa1hy1Gq8SkToTAi2FKOp0V8FUSdgORIIg5Z+ycdG+77BDOn9i+ZW1h8/LP?= =?us-ascii?Q?kAzMw0IbYYJUSZWsg0HFFHdOxiaKR2hX2CuNGuUUVzN070QHNafH4dIiNbE5?= =?us-ascii?Q?VtGih6aEtH7In508Az/qs00u9Qcw4LIG0rJ/TT4FKBENMO5EE1e0HN2l6NIq?= =?us-ascii?Q?PaFIQCcuYMGHNWMr7FPh+I8TNGRthCS5icCLlQgo+X125CcHqu0SJuQvxRjQ?= =?us-ascii?Q?IITDb/XA9Ca1/zQLnmrtajVr6BemLsiJZqU7scFum8eITdlMm2KhBfu7fV/m?= =?us-ascii?Q?/YNgcXC8HIY9EpJsuFQ9mSP2Ktb94G+0JG/RP1o6kD7PGbHRrBYZnc6h4012?= =?us-ascii?Q?bM+Mm/BL3yZ2V1lmgGvkzIb1eL0RrKagRO4E/USSHexW3XOR1bVTFVVh0qxR?= =?us-ascii?Q?y0dQ4s60GyswlAsG0KiBQx/PpwltySqm6dcYGSyYOIQSi3w0pdcInbOm+KOY?= =?us-ascii?Q?SN6O11M39WWKrxCo7y2zbQ8g+AGmIJUrLZ9skq1ryBYjnK9HVP3oAYej+Mri?= =?us-ascii?Q?Lzs8lrJAqcChTdW2mbeqMXiFNey7iwZX5cbvxZx8Uh2sRNtBcYyQRz0ykJjm?= =?us-ascii?Q?2YnS+53U0lMrTiKoAeWuySyquUU+ENUVBvOVtZQP7nvMtK3I/9xDcZty3ni+?= =?us-ascii?Q?rl7iHx+KzpKADCkjk1PT7/gokRQjhA485oUwrMF7x5eoosvBEJIKoIusJNo9?= =?us-ascii?Q?HW1LqrET10vMe8ebnq+vQjmXM7PK4ii+McblfCpR2/HXx/JIsvvAF6Zbrnab?= =?us-ascii?Q?SY9+RKxzVSHT3X/Y0U7W6xVvlkobm98uMB6e9NEsiJzE/C6yYOIAUDvehTGU?= =?us-ascii?Q?OI9NjpHU/+7rfhkpLR6uNveTUM4Kv2Hx/xxiI2/0z0gZY3aZUnkoj3AAmUo9?= =?us-ascii?Q?+PNG2t7HECI0XPIIyi1ipH5OAKnY/6SLfs0RA3EJ5wMhHr8bAF+MWRSe7EHo?= =?us-ascii?Q?84xrd399qFiDpjBr7lFSUvQUngNrKw46e/VBhT4owmcFsWahFd8pIXf2LU47?= =?us-ascii?Q?d7kcXcK6A+gFojS00oVEXjqEuvgX5MH8Tk+qiFB6RDRufOcUNciJOjMcVdRN?= =?us-ascii?Q?d0L9uPE9Mp3X8MrwoiwA8Uu2dwxfAEEqGq6R+7R9fFpVs9NPtKMFSzgRA/VG?= =?us-ascii?Q?syoSkeAywVNfNok/VdDJMHLHkDJWeKg0f5nc0PuKWIsAt9sm9+o2EjYeWooM?= =?us-ascii?Q?wHBOAHNk2spOrWkikzcD/QdWrIm0eqMzjopyNpZa?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB5946.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 46ee3aec-ea59-47b4-7840-08dab23c9899 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Oct 2022 01:44:15.4009 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GfvnjDdAnT1ytl/8BqvCU9mqL6pLpm2KzTo4FlY//1jICviFz6VBudA3i0OdeDSEu6DfYOwaAba25UWne+cAHA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB7093 X-OriginatorOrg: intel.com X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > -----Original Message----- > From: Segher Boessenkool > Sent: Thursday, October 20, 2022 5:14 AM > To: Andrew Pinski > Cc: Jiang, Haochen ; gcc-patches@gcc.gnu.org; > aoliva@gcc.gnu.org; richard.sandiford@arm.com; uweigand@de.ibm.com; > linkw@gcc.gnu.org; gnu@amylaar.uk; dje.gcc@gmail.com; > olegendo@gcc.gnu.org; claziss@synopsys.com; mfortune@gmail.com; > davem@redhat.com; dave.anglin@bell.net; hubicka@ucw.cz; > richard.earnshaw@arm.com; rguenther@suse.de; > marcus.shawcroft@arm.com; ramana.radhakrishnan@arm.com; Liu, Hongtao > > Subject: Re: [PATCH 1/2] Add a parameter for the builtin function of pref= etch > to align with LLVM >=20 > On Wed, Oct 19, 2022 at 10:14:28AM -0700, Andrew Pinski wrote: > > Do the testcases really need to be changed rather than adding new > testcases? > > Usually it is better if the testcases not change unless really needed > > to be. That is do these testcases pass without being changed? If not > > this seems not backwards compatible change and is not something which > > we should do. Otherwise you should just add new testcases instead. >=20 > Yes, that is another reason why adding parameters to random builtins is n= ot a > good idea :-) s/random/only vaguely related/, if you want. >=20 > This also makes all existing code using these builtins invalid. If you n= eed such > testcase changes, that is a red flag. >=20 Maybe the testcase change cause some misunderstanding and concern. Actually, the patch did not disrupt the previous builtins, as the builtin_p= refetch uses vargs. I set the default value of the new parameter as data prefetch, = which means that if we are not using the fourth parameter, just like how we use prefetch previously, it is still what it is. The reason why I did the most of the testcase change is to make it looks mo= re completed at the parameter side. I could take back that change on adding parameter in current testcases just add tests related to new parameter, whi= ch is a minimal change to current test I suppose. BRs, Haochen >=20 > Segher