From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by sourceware.org (Postfix) with ESMTPS id 64A0E385802A; Fri, 21 Oct 2022 03:17:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 64A0E385802A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666322260; x=1697858260; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=gViTOX8g9OqvDPTrHKKUnNuuqFEeLsNElt/w4iUv21Y=; b=SfjdKdarlmHnQxg4g8028aev0z9+SUxf0gn8bzV9Ij18K6zQhFFP8xJU asCmMK23sJgDbx5hqVKVV4S0ac1Vv5+CtuRCokgeJUgKqKE6/5cCBLCAz tuMEtJMUHwfqBE61arXeaq1q7k0QxQOcGSdVbymbjV4gZhY3s456uz/I2 q0JRq4iN6XIzPnckuAp04jLSjPUnPGTKsv8OiJ7/HXQttl8ghxYATKBDy DJI7Z23glinNeZ6aEtyCbcvBnElc3zJ+6e+MSGdoI5xMv7ze5p7f3D1Dn 7Pk0IU/NT6kW6X2pVKvT3Uf71lgYi29webKpfcOROXXuKaaA6y/cJwxbU g==; X-IronPort-AV: E=McAfee;i="6500,9779,10506"; a="371112983" X-IronPort-AV: E=Sophos;i="5.95,200,1661842800"; d="scan'208";a="371112983" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2022 20:17:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10506"; a="661334778" X-IronPort-AV: E=Sophos;i="5.95,200,1661842800"; d="scan'208";a="661334778" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga008.jf.intel.com with ESMTP; 20 Oct 2022 20:17:38 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 20 Oct 2022 20:17:38 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 20 Oct 2022 20:17:37 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Thu, 20 Oct 2022 20:17:37 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.170) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Thu, 20 Oct 2022 20:17:37 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TmtJh8G8HRyH5YK/TxKh8dTzKCT2y3+QcFu97gsZPu56Qe1q2KCvI0Ee2CY58ZLTWLBW5sUnmjSFoUQNLjePKUQ1/wSdzhfNVngoNOECAfEmBkVZi0PxHQTWtRKIKWMqq8Iy4ZFNEmeO8yC7ixtVyEpwd6BJhu9SsmjM4he/hLpq017AlPVxek0FtriWU09Q3CchIlKROa2tl6HHnNzvKmW/1NmvmKSrHpX80ls5HlF/K1YeADyI4dqbd8+x4jgKDhgSsBuQplnU7L2G6pkyM/a8ClDXJpzUTtbJzswQtnrDPYBnPikmfiu6QrX22eNCdnm47l/EkV3+UuouHf3jjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CE7PpmgNszoVzf2yjNyMF6f7EMhrMP5xxPzdy1NIk8o=; b=XbxclvRKd1naEWh8Z7X5ltVhYe5455cGArEFedFt9WqHXvmafFjRXqeqVQj+qbDLZmfDTPGTX9Jfosw1oePz0DARsnV8Pzg95+STjlM13AJTOpqi5akmPejvv7CZoN9zmNyu7zlTkQD/bTtqTxjwd/qAVqle1cXGYDOai97+ta+UO5XWAN42kWywi17mm2pXKPJyo4YbQq7wo8cnfTulVT5Ua8b3EsV6XuSc1nC+NOdCN+odx/FvvedHOHwfFKsFZOsKURuqGxXiByXHOxgnE8i/qvbJb5rVSCk+/zWIIrxVIvSc2Di9Qx/9UrH7jdZz1rhWUvc8JjeFa9iS65ehaw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA1PR11MB5946.namprd11.prod.outlook.com (2603:10b6:806:23a::9) by MW4PR11MB5909.namprd11.prod.outlook.com (2603:10b6:303:168::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30; Fri, 21 Oct 2022 03:17:35 +0000 Received: from SA1PR11MB5946.namprd11.prod.outlook.com ([fe80::3580:2e13:aa4b:d98d]) by SA1PR11MB5946.namprd11.prod.outlook.com ([fe80::3580:2e13:aa4b:d98d%3]) with mapi id 15.20.5723.033; Fri, 21 Oct 2022 03:17:35 +0000 From: "Jiang, Haochen" To: Segher Boessenkool CC: "gcc-patches@gcc.gnu.org" , "rguenther@suse.de" , "Liu, Hongtao" , "ubizjak@gmail.com" , "richard.earnshaw@arm.com" , "richard.sandiford@arm.com" , "marcus.shawcroft@arm.com" , "kyrylo.tkachov@arm.com" , "rth@gcc.gnu.org" , "gnu@amylaar.uk" , "claziss@synopsys.com" , "nickc@redhat.com" , "ramana.radhakrishnan@arm.com" , "aoliva@gcc.gnu.org" , "hubicka@ucw.cz" , "mfortune@gmail.com" , "dje.gcc@gmail.com" , "linkw@gcc.gnu.org" , "uweigand@de.ibm.com" , "krebbel@linux.ibm.com" , "olegendo@gcc.gnu.org" , "davem@redhat.com" , "ebotcazou@libertysurf.fr" , "jeffreyalaw@gmail.com" , "dave.anglin@bell.net" Subject: RE: [PATCH 1/2] Add a parameter for the builtin function of prefetch to align with LLVM Thread-Topic: [PATCH 1/2] Add a parameter for the builtin function of prefetch to align with LLVM Thread-Index: AQHY36iHla+IM3KeSkqbg3kXafqqFq4WPhKAgABPYeCAAR3vgIAAeKyA Date: Fri, 21 Oct 2022 03:17:35 +0000 Message-ID: References: <20221014083406.8406-1-haochen.jiang@intel.com> <20221014083406.8406-2-haochen.jiang@intel.com> <20221019210645.GP25951@gate.crashing.org> <20221020185415.GU25951@gate.crashing.org> In-Reply-To: <20221020185415.GU25951@gate.crashing.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.500.17 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA1PR11MB5946:EE_|MW4PR11MB5909:EE_ x-ms-office365-filtering-correlation-id: 64272f05-2285-4150-83aa-08dab312cd04 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7FL8nmZteZnb6/TjIUhlmknt+AfAt6cqW6BsMq1iHzX64MZ4g9yK0N+lL3Pxyd/cyXVMwD480nAa+ylk7tfDz0N4QJpsus8OWF9ErHCxoyp7tgJJySZ57qqBoPxPsru9l3jAUpenyy50SQVF5G9BMcToztBJIbdEhGlxxgf4Zmwp0sUGHD6Ih9D/96o8hAU2miHuBzv4t505jHTHeTS740U+GzBynwp3EHgF+Jmv4HOnDvP1T311aX6Aqu2TMCJJTt/yOqymLvJfd0JJn41/d9ELgnl4fiiB7l23/wLfUtlHy2NEcpXmQWevH86X66ftDDprz/fv00hiprnJwX28NPEP4Ldy0Bj1kqDJT6JYyfljsIJ5s9gfvjeTWzrMtpu5Ra/ZHn34dE343JGjyS9bIuhkSkcuBQ1bY0tvkrzq8lMotwtRFpsojDVASC91fR1/31I06Y44Ut5bnFYeAUmRTCLejeGdQEM6gtjFxBLiw34wJ0n/NbTR6FAtkrORxOPTpRrgmh+V/OFchLYvSoBgJGTEWKv8W4k/qtpSCEcQZ0M7OqdBIIR/6ltxs+JPPrOCgmmNAn1Vy6fsh3hYGmg/pCe5HQV5kox5mxYvG/M38rrr66usX3DeQSSYskWfkbqwFxxMVH7FPRJ+EawGzIECW140ebYxuzalFTCScHm+WfL5T12WKsN6v6wF/JpiOyubRuJa7EFoJcx2/ro9BcyF4YIh44/ZcN+OmC6bGXxYnt2SKDXFcbU66v5qlq2qhyF/sZQKxPQ9KhG6nQ0RebjlB0R1wdKtgV/9YUGdd2NuEvI= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR11MB5946.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(396003)(346002)(366004)(136003)(376002)(451199015)(26005)(64756008)(54906003)(6916009)(316002)(9686003)(83380400001)(8936002)(33656002)(5660300002)(2906002)(76116006)(66476007)(86362001)(66946007)(66446008)(7416002)(66556008)(186003)(122000001)(53546011)(41300700001)(38070700005)(8676002)(55016003)(4326008)(6506007)(7696005)(82960400001)(52536014)(71200400001)(38100700002)(478600001)(41080700001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?KMr66Ka8NK+De5C1qxIVQ8WMUjqULja5n8OK6K51EMNj9OjhQPiadCAq2QgU?= =?us-ascii?Q?kdZbR4WYhZIWM/iIQ3zHXNTiMepEZunFB1c50efXzvOwJUcIoWqOC1KU26Gg?= =?us-ascii?Q?4DDSj9g6NC8kVuC+Rn3BHXB+mDgq3k17jbtXhD6t9ITulV3XqRiJmQ0NVHum?= =?us-ascii?Q?f1ONJDyVWa8mGADThpBxQSK2qAR2PEKoDnNCaK6Kh2ePgaFt9cmZMB1J8Mn4?= =?us-ascii?Q?dybhuBiim8xaBJQ0h04n6XNv3I08fvpQF+8mxW7jLaqWwgRcRTYWfIfJiaFw?= =?us-ascii?Q?yeyd3KaY2wIt+ZZAtRjaPjW6mVj1ABOGc/dAxTHhSx4RdRHzHvpFIbu7zKFU?= =?us-ascii?Q?DP/1NqFDURMxwdWsJ5ymZqikLjvpALKm8pnFFOR7xKTDYKE4tZFx42a7K8Ln?= =?us-ascii?Q?P076y7S126lAW15jSwL8aYGlKT7+Dz1caD/Mif249KPSoo0voApA1pi6DLbF?= =?us-ascii?Q?EQ6+DPwaj1sUbQG2qn8hJ1h4oazRTveklBPe0RiYAfYotapBRlqzGRMBM5Kn?= =?us-ascii?Q?tWtSgCuIKR6NJymmM2BukmbGjJ0KUhL2nGE+5ZTE8wYuwmZCJ0sEFjNPNsBJ?= =?us-ascii?Q?Xf/89pp3D2XTdLrkKK+p0MUaOMLUz5RlBz9Ku+totgYkXLU6wxBD59722tS5?= =?us-ascii?Q?EyewewvCOIsaouAth+frgF1F9JkIVy6dwKD1j1WsnxsQOvkhz2G2T4HsHG91?= =?us-ascii?Q?rROxxKRkEUcV+0YpQlMu0R3RDmtBTbRpb3/m/hACqg98dcJ6AX4IPWadR1jK?= =?us-ascii?Q?ZEzkApVo5BgWh5zE3OG9GTb78mtANYBRAzAUEk6QiMqzuXKN4OiOCg/4UxWf?= =?us-ascii?Q?cNdtb0ATZ2B/sAkt+dQJf5hzakgziTeZHnAfcCWO+TEFc0F+HU6G5nNkmxvI?= =?us-ascii?Q?mlnGEkuMBdVZT48TI54ZBYwckcp+dvK2CcT9I8mSlRLR9dLj7Hup7+4U1I9c?= =?us-ascii?Q?DU/6cs4PILk8BG4xU93kM3YNr0IohCt9BAqu8cAillZAEHz7m20HtRzLZxfM?= =?us-ascii?Q?2P9+JWZGg3oJKEjY4tjLwI0831jzNOVjIRKHInWeq6R2306LO3W3vLNwcj7F?= =?us-ascii?Q?TTJaXIH0kfZc2Y2CoX1K4vQw5jAcu72tBKQVKJANDaqiD5gt9Zf5+cK/teY3?= =?us-ascii?Q?D7W2ayJkb74c9EFy2eM1fVqA6qZ4eopLqxeRVUCrFNkOmvGJG0vsKFBAsmmu?= =?us-ascii?Q?U+YZxH0yqzRXgwToJ7RtiH1uMc/eG1UK/pzbe+wf37eeTgnDNUoi6jJYdIcr?= =?us-ascii?Q?HCOxvGYwgnu4WkHQr9KNHX49U49vlN3DpAcvpt9J4UBP/urTjrxCJKEyn27g?= =?us-ascii?Q?9Rt3/RDKDyaG1ZkUYDmVN9KXau5lbQ+xZIWIB7B6lFtkc2cIX3x1pii9eOaE?= =?us-ascii?Q?P8nn98ME4JBnZWVXRQbkMK1XBZIH4JIySGzN/rwoRwiJXRNhAHYmgDCCpTMP?= =?us-ascii?Q?erPapnzJx9ud2+Y3TscktPAb5hR0GQkkvH7OBz4LEXBzA1HmiCrYVtRp1i5Z?= =?us-ascii?Q?jJ8QgL8AYotUG2Qo3O3pXhBC8APpMFlutBt1/g+bAgl3KCBDsXT72wdLo4E9?= =?us-ascii?Q?4vrleY/vygrRk4LAuinbs263QX9Z0lOdy1vwjeFs?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB5946.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 64272f05-2285-4150-83aa-08dab312cd04 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Oct 2022 03:17:35.6442 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: QxJ8l1iX0UR2GXmHHjlPr90qXhX/sZfFwTz5tS8vBL2TiC0GK3wunf6jDAjUzBfVgzS/txfE2w+yCQy2knhQnQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB5909 X-OriginatorOrg: intel.com X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > -----Original Message----- > From: Segher Boessenkool > Sent: Friday, October 21, 2022 2:54 AM > To: Jiang, Haochen > Cc: gcc-patches@gcc.gnu.org; rguenther@suse.de; Liu, Hongtao > ; ubizjak@gmail.com; richard.earnshaw@arm.com; > richard.sandiford@arm.com; marcus.shawcroft@arm.com; > kyrylo.tkachov@arm.com; rth@gcc.gnu.org; gnu@amylaar.uk; > claziss@synopsys.com; nickc@redhat.com; ramana.radhakrishnan@arm.com; > aoliva@gcc.gnu.org; hubicka@ucw.cz; mfortune@gmail.com; > dje.gcc@gmail.com; linkw@gcc.gnu.org; uweigand@de.ibm.com; > krebbel@linux.ibm.com; olegendo@gcc.gnu.org; davem@redhat.com; > ebotcazou@libertysurf.fr; jeffreyalaw@gmail.com; dave.anglin@bell.net > Subject: Re: [PATCH 1/2] Add a parameter for the builtin function of pref= etch > to align with LLVM >=20 > On Thu, Oct 20, 2022 at 07:34:13AM +0000, Jiang, Haochen wrote: > > > > + /* Argument 3 must be either zero or one. */ > > > > + if (INTVAL (op3) !=3D 0 && INTVAL (op3) !=3D 1) > > > > + { > > > > + warning (0, "invalid fourth argument to %<__builtin_prefetch= %>;" > > > > + " using one"); > > > > > > "using 1" makes sense maybe, but "using one" reads as "using an > > > argument", not very sane. > > > > > > An error would be better here anyway? > > > > Will change to 1 to avoid confusion in that. The reason why this is a w= arning > > is because previous ones related to constant arguments out of range in > prefetch > > are also using warning. >=20 > Please don't repeat historical mistakes. You might not want to fix the > existing code (since that can in theory break existing user code), but > that is not a reason to punish users of a new feature as well ;-) >=20 > > > Please use a separate pattern for this, and leave prefetch to mean da= ta > > > prefetch, as documented! Documentation you didn't change btw. Call > the > > > new one instruction_prefetch or something equally boring maybe :-) > > > > Actually I changed documentation for prefetch but it is flooded in the = patch > > (Sorry for that). >=20 > Oh huh, I looked for it but didn't find it. Another argument for making > better patch series ;-) >=20 > > 1. Previously we are using parameter to indicate r/w and locality in pr= efetch. > I > > suppose it is quite similar in this case. Since the pattern is already = there, I > prefer > > reusing them. >=20 > You can use the data prefetch RTL code for all data loads just as well, > it is more closely related than this -- but most people would call that > insanity! Maybe you got me here. I suppose I will write another patch for a new RTL t= o see which implementation is better. Thx, Haochen >=20 >=20 > Segher