From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9328 invoked by alias); 16 Feb 2016 04:51:04 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 9311 invoked by uid 89); 16 Feb 2016 04:51:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=enhances, type_mode, TYPE_MODE, scmp X-HELO: na01-bn1-obe.outbound.protection.outlook.com Received: from mail-bn1bon0076.outbound.protection.outlook.com (HELO na01-bn1-obe.outbound.protection.outlook.com) (157.56.111.76) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA256 encrypted) ESMTPS; Tue, 16 Feb 2016 04:51:01 +0000 Received: from SN2PR0701MB1024.namprd07.prod.outlook.com (10.160.57.150) by BN4PR07MB2147.namprd07.prod.outlook.com (10.164.63.17) with Microsoft SMTP Server (TLS) id 15.1.409.15; Tue, 16 Feb 2016 04:50:58 +0000 Received: from SN2PR0701MB1024.namprd07.prod.outlook.com ([10.160.57.150]) by SN2PR0701MB1024.namprd07.prod.outlook.com ([10.160.57.150]) with mapi id 15.01.0403.019; Tue, 16 Feb 2016 04:50:58 +0000 From: "Hurugalawadi, Naveen" To: Richard Biener , Senthil Kumar Selvaraj CC: "gcc-patches@gcc.gnu.org" , "Pinski, Andrew" Subject: Re: PATCH] Fix PR 31531: A microoptimization of isnegative of signed integer Date: Tue, 16 Feb 2016 04:51:00 -0000 Message-ID: References: <87egcn7eae.fsf@atmel.com>, In-Reply-To: authentication-results: gcc.gnu.org; dkim=none (message not signed) header.d=none;gcc.gnu.org; dmarc=none action=none header.from=caviumnetworks.com; x-microsoft-exchange-diagnostics: 1;BN4PR07MB2147;5:ZH33CVtutlmScjaK0vfI7jf/lMO3BSuP/iGf7qfIeMf+AxQAl8RgmSyYkw+UtRfU5yu7mURTmdjqPg0Gtl3z9dde3pb7V2H2ZmtfOE6kCaWRc6JkTz/0DoiINcWEqkR7W1j1a6K/jO3t4kCfEDOAuA==;24:KwL/IEwDKvFtaXRR7ji8AQXp5U7y5r1g/E7HAeewirjonQl6lLRa7l4IqsruHsvq2CIqKnjECQS42MkuCakz0ptKSh0dc1AQmh/osx2joJI= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN4PR07MB2147; x-ms-office365-filtering-correlation-id: 4db8376d-666e-40e2-5cce-08d3368cc2d6 x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(102415293)(102615271)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001);SRVR:BN4PR07MB2147;BCL:0;PCL:0;RULEID:;SRVR:BN4PR07MB2147; x-forefront-prvs: 0854128AF0 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(164054003)(10400500002)(107886002)(33656002)(87936001)(2906002)(5001960100002)(189998001)(5001770100001)(3660700001)(54356999)(5890100001)(2950100001)(3280700002)(4326007)(99936001)(66066001)(76176999)(76576001)(50986999)(5002640100001)(106116001)(586003)(40100003)(92566002)(1220700001)(6116002)(3846002)(102836003)(122556002)(558084003)(11100500001)(5003600100002)(74316001)(99286002)(86362001)(4001430100002)(5008740100001)(1096002)(5004730100002)(2900100001)(77096005);DIR:OUT;SFP:1101;SCL:1;SRVR:BN4PR07MB2147;H:SN2PR0701MB1024.namprd07.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: multipart/mixed; boundary="_002_SN2PR0701MB1024F4E510034BC0F61FC0348EAD0SN2PR0701MB1024_" MIME-Version: 1.0 X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Feb 2016 04:50:57.6677 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN4PR07MB2147 X-SW-Source: 2016-02/txt/msg01035.txt.bz2 --_002_SN2PR0701MB1024F4E510034BC0F61FC0348EAD0SN2PR0701MB1024_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-length: 235 Hi, >> I'm also failing to see why you can't enhance the existing Please find attached the patch that enhances the existing pattern. Please review the patch and let me know if any further modifications are required. Thanks, Naveen= --_002_SN2PR0701MB1024F4E510034BC0F61FC0348EAD0SN2PR0701MB1024_ Content-Type: text/x-diff; name="pr31531-1.patch" Content-Description: pr31531-1.patch Content-Disposition: attachment; filename="pr31531-1.patch"; size=1749; creation-date="Tue, 16 Feb 2016 04:50:38 GMT"; modification-date="Tue, 16 Feb 2016 04:50:38 GMT" Content-Transfer-Encoding: base64 Content-length: 2371 ZGlmZiAtLWdpdCBhL2djYy9tYXRjaC5wZCBiL2djYy9tYXRjaC5wZAppbmRl eCA2YzhlYmQ1Li5iZDQ3YTkxIDEwMDY0NAotLS0gYS9nY2MvbWF0Y2gucGQK KysrIGIvZ2NjL21hdGNoLnBkCkBAIC0xODcxLDEwICsxODcxLDIxIEBAIERF RklORV9JTlRfQU5EX0ZMT0FUX1JPVU5EX0ZOIChSSU5UKQogKGZvciBjbXAg KHNpbXBsZV9jb21wYXJpc29uKQogICAgICBzY21wIChzd2FwcGVkX3NpbXBs ZV9jb21wYXJpc29uKQogIChzaW1wbGlmeQotICAoY21wIChiaXRfbm90QDIg QDApIENPTlNUQU5UX0NMQVNTX1BAMSkKKyAgKGNtcCAoY29udmVydD9AMyAo Yml0X25vdEAyIEAwKSkgQ09OU1RBTlRfQ0xBU1NfUEAxKQogICAoaWYgKHNp bmdsZV91c2UgKEAyKQotICAgICAgICYmIChUUkVFX0NPREUgKEAxKSA9PSBJ TlRFR0VSX0NTVCB8fCBUUkVFX0NPREUgKEAxKSA9PSBWRUNUT1JfQ1NUKSkK LSAgIChzY21wIEAwIChiaXRfbm90IEAxKSkpKSkKKyAgICAgICAmJiAoKFRS RUVfQ09ERSAoQDEpID09IElOVEVHRVJfQ1NUICYmIFRSRUVfVFlQRSAoQDMp ID09IFRSRUVfVFlQRSAoQDIpKQorICAgICAgICAgICAgfHwgKFRSRUVfQ09E RSAoQDEpID09IFZFQ1RPUl9DU1QKKwkJJiYgKFZFQ1RPUl9UWVBFX1AgKFRS RUVfVFlQRSAoQDMpKQorCQkgICAgPT0gVkVDVE9SX1RZUEVfUCAoVFJFRV9U WVBFIChAMikpKQorCQkmJiAoVFlQRV9WRUNUT1JfU1VCUEFSVFMgKFRSRUVf VFlQRSAoQDMpKQorCQkgICAgPT0gVFlQRV9WRUNUT1JfU1VCUEFSVFMgKFRS RUVfVFlQRSAoQDIpKSkKKwkJJiYgKFRZUEVfTU9ERSAoVFJFRV9UWVBFIChU UkVFX1RZUEUgKEAzKSkpCisJCSAgICA9PSBUWVBFX01PREUgKFRSRUVfVFlQ RSAoVFJFRV9UWVBFIChAMikpKSkpKSkKKyAgIChzY21wIEAwIChiaXRfbm90 IEAxKSkKKyAgKGlmIChUWVBFX1BSRUNJU0lPTiAoVFJFRV9UWVBFIChAMykp ID09IFRZUEVfUFJFQ0lTSU9OIChUUkVFX1RZUEUgKEAyKSkKKyAgICAgICAm JiAoVFJFRV9DT0RFIChAMSkgPT0gSU5URUdFUl9DU1QpKQorICAgKHdpdGgg eyB0cmVlIG5ld3R5cGUgPSBUUkVFX1RZUEUgKEAxKTsgfQorICAgIChzY21w IChjb252ZXJ0Om5ld3R5cGUgQDApIChiaXRfbm90IEAxKSkpKSkpKQogCiAo Zm9yIGNtcCAoc2ltcGxlX2NvbXBhcmlzb24pCiAgLyogRm9sZCAoZG91Ymxl KWZsb2F0MSBDTVAgKGRvdWJsZSlmbG9hdDIgaW50byBmbG9hdDEgQ01QIGZs b2F0Mi4gICovCmRpZmYgLS1naXQgYS9nY2MvdGVzdHN1aXRlL2djYy5kZy9w cjMxNTMxLmMgYi9nY2MvdGVzdHN1aXRlL2djYy5kZy9wcjMxNTMxLmMKbmV3 IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uY2Y5ZGQ4MgotLS0g L2Rldi9udWxsCisrKyBiL2djYy90ZXN0c3VpdGUvZ2NjLmRnL3ByMzE1MzEu YwpAQCAtMCwwICsxLDE1IEBACisvKiB7IGRnLWRvIGNvbXBpbGUgfSAqLwor LyogeyBkZy1vcHRpb25zICItZmR1bXAtdHJlZS1naW1wbGUiIH0gKi8KKy8q IHsgZGctcmVxdWlyZS1lZmZlY3RpdmUtdGFyZ2V0IGludDMyIH0gKi8KKwor aW50IGlzbmVnYXRpdmVfb3B0aW1pemVkXzQgKHVuc2lnbmVkIGludCBYKQor eworICBpbnQgcmVzdWx0OworICBpZiAoKH5YKSA+PiAzMSkKKyAgICByZXN1 bHQgPSAwOworICBlbHNlCisgICAgcmVzdWx0ID0gMTsKKyAgcmV0dXJuIHJl c3VsdDsKK30KKworLyogeyBkZy1maW5hbCB7IHNjYW4tdHJlZS1kdW1wLXRp bWVzICJzaWduZWQgaW50IFguMCIgMSAiZ2ltcGxlIiB9IH0gKi8K --_002_SN2PR0701MB1024F4E510034BC0F61FC0348EAD0SN2PR0701MB1024_--