public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Di Zhao OS <dizhao@os.amperecomputing.com>
To: Richard Sandiford <richard.sandiford@arm.com>,
	Philipp Tomsich <philipp.tomsich@vrull.eu>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: RE: [PATCH] Change fma_reassoc_width tuning for ampere1
Date: Sat, 29 Jul 2023 14:22:45 +0000	[thread overview]
Message-ID: <SN6PR01MB42404A4518A2CEAA11684A4FE807A@SN6PR01MB4240.prod.exchangelabs.com> (raw)
In-Reply-To: <mptpm5icn8r.fsf@arm.com>

Cherry-picked this to gcc-13.

Thanks,
Di Zhao

> -----Original Message-----
> From: Richard Sandiford <richard.sandiford@arm.com>
> Sent: Monday, June 26, 2023 10:28 PM
> To: Philipp Tomsich <philipp.tomsich@vrull.eu>
> Cc: Di Zhao OS via Gcc-patches <gcc-patches@gcc.gnu.org>; Di Zhao OS
> <dizhao@os.amperecomputing.com>
> Subject: Re: [PATCH] Change fma_reassoc_width tuning for ampere1
> 
> Philipp Tomsich <philipp.tomsich@vrull.eu> writes:
> > Richard,
> >
> > OK for backport to GCC-13?
> 
> Yeah, OK for GCC 13 too.
> 
> Thanks,
> Richard
> 
> > Thanks,
> > Philipp.
> >
> > On Thu, 22 Jun 2023 at 16:18, Richard Sandiford via Gcc-patches
> > <gcc-patches@gcc.gnu.org> wrote:
> >>
> >> Di Zhao OS via Gcc-patches <gcc-patches@gcc.gnu.org> writes:
> >> > This patch enables reassociation of floating-point additions on ampere1.
> >> > This brings about 1% overall benefit on spec2017 fprate cases. (There
> >> > are minor regressions in 510.parest_r and 508.namd_r, analyzed here:
> >> > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110279 .)
> >> >
> >> > Bootstrapped and tested on aarch64-unknown-linux-gnu. Is this OK for
> trunk?
> >> >
> >> > Thanks,
> >> > Di Zhao
> >> >
> >> > gcc/ChangeLog:
> >> >
> >> >         * config/aarch64/aarch64.cc: Change fma_reassoc_width for
> ampere1
> >>
> >> Thanks, pushed to trunk.
> >>
> >> Richard
> >>
> >> > ---
> >> > diff --git a/gcc/config/aarch64/aarch64.cc
> b/gcc/config/aarch64/aarch64.cc
> >> > index d16565b5581..301c9f6c0cd 100644
> >> > --- a/gcc/config/aarch64/aarch64.cc
> >> > +++ b/gcc/config/aarch64/aarch64.cc
> >> > @@ -1927,7 +1927,7 @@ static const struct tune_params ampere1_tunings =
> >> >    "32:12",   /* loop_align.  */
> >> >    2, /* int_reassoc_width.  */
> >> >    4, /* fp_reassoc_width.  */
> >> > -  1, /* fma_reassoc_width.  */
> >> > +  4, /* fma_reassoc_width.  */
> >> >    2, /* vec_reassoc_width.  */
> >> >    2, /* min_div_recip_mul_sf.  */
> >> >    2, /* min_div_recip_mul_df.  */

      reply	other threads:[~2023-07-29 14:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-20  3:58 Di Zhao OS
2023-06-22 14:17 ` Richard Sandiford
2023-06-22 14:23   ` Philipp Tomsich
2023-06-26 14:27     ` Richard Sandiford
2023-07-29 14:22       ` Di Zhao OS [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SN6PR01MB42404A4518A2CEAA11684A4FE807A@SN6PR01MB4240.prod.exchangelabs.com \
    --to=dizhao@os.amperecomputing.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=philipp.tomsich@vrull.eu \
    --cc=richard.sandiford@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).