From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from MTA-10-4.privateemail.com (mta-10-4.privateemail.com [198.54.122.149]) by sourceware.org (Postfix) with ESMTPS id 7E5D93858D28 for ; Mon, 30 Oct 2023 22:00:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7E5D93858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=effective-light.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=effective-light.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7E5D93858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=198.54.122.149 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698703215; cv=none; b=gae/3F9vTSunX7RDXYk7WMSEuLH+ljtgdVtUYM/fKQHcKfDmT0/R20ifAxBRTlDgCAU647tSOrRz+Rs2w1hUln3DxTW4uQfGevL9egWesi6ToxZpCHrAZ2CTikK2n/xWWZiob571/sncX9etrTGFQ14QoXOb50cQ6+ltMGzs8bw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698703215; c=relaxed/simple; bh=ZtlIKMcNlVNfFoOvbj4mDzoXLK2qJJKCHuVIF2Q+79M=; h=Date:From:Subject:To:Message-Id:MIME-Version; b=Swl024qjLmAeXKXfLa/E5AGGhsUFNMcCEeCJp0vhFwCn12pYjky+yGpmlbBkCQXOk8u7oErrYm3NMwR5rCADkpxPbrPuVVAJ1R91s2sLkjcNk2ROa+0/b4x1W4RYFY8duLyo8cw3CYcJXcjETSuyVhRaxJQseB3hrQl3NToTe6s= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from mta-10.privateemail.com (localhost [127.0.0.1]) by mta-10.privateemail.com (Postfix) with ESMTP id 3A67E180004C; Mon, 30 Oct 2023 18:00:11 -0400 (EDT) Received: from [192.168.2.177] (unknown [184.147.247.141]) by mta-10.privateemail.com (Postfix) with ESMTPA; Mon, 30 Oct 2023 18:00:03 -0400 (EDT) Date: Mon, 30 Oct 2023 17:59:52 -0400 From: Hamza Mahfooz Subject: Re: [PATCH v2] c: don't emit -Wmissing-variable-declarations for register variables [PR110947] To: gcc-patches@gcc.gnu.org Cc: Nick Desaulniers , Nathan Chancellor , Richard Biener , Joseph Myers , Marek Polacek , Martin Uecker Message-Id: In-Reply-To: <20230901190241.157034-1-someguy@effective-light.com> References: <20230901190241.157034-1-someguy@effective-light.com> X-Mailer: geary/44.1 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed X-Virus-Scanned: ClamAV using ClamSMTP X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: ping On Fri, Sep 1 2023 at 03:02:41 PM -04:00:00, Hamza Mahfooz wrote: > Resolves: > PR c/110947 - Should -Wmissing-variable-declarations not trigger on > register variables? > > gcc/c/ChangeLog: > > PR c/110947 > * c-decl.cc (start_decl): don't emit > -Wmissing-variable-declarations for DECL_REGISTER VAR_DECLs. > > gcc/testsuite/ChangeLog: > > PR c/110947 > * gcc.dg/pr110947.c: New test. > > Signed-off-by: Hamza Mahfooz > --- > Please push this for me if you think it looks good. Since, I don't > have > write access to the repository. > > v2: put "target" before the relevant architectures in pr110947.c. > --- > gcc/c/c-decl.cc | 3 ++- > gcc/testsuite/gcc.dg/pr110947.c | 4 ++++ > 2 files changed, 6 insertions(+), 1 deletion(-) > create mode 100644 gcc/testsuite/gcc.dg/pr110947.c > > diff --git a/gcc/c/c-decl.cc b/gcc/c/c-decl.cc > index 1f9eb44dbaa..819af6aa050 100644 > --- a/gcc/c/c-decl.cc > +++ b/gcc/c/c-decl.cc > @@ -5376,7 +5376,8 @@ start_decl (struct c_declarator *declarator, > struct c_declspecs *declspecs, > warning (OPT_Wmain, "%q+D is usually a function", decl); > > if (warn_missing_variable_declarations && VAR_P (decl) > - && !DECL_EXTERNAL (decl) && TREE_PUBLIC (decl) && old_decl == > NULL_TREE) > + && !DECL_EXTERNAL (decl) && !DECL_REGISTER (decl) && > TREE_PUBLIC (decl) > + && old_decl == NULL_TREE) > warning_at (DECL_SOURCE_LOCATION (decl), > OPT_Wmissing_variable_declarations, > "no previous declaration for %qD", decl); > > diff --git a/gcc/testsuite/gcc.dg/pr110947.c > b/gcc/testsuite/gcc.dg/pr110947.c > new file mode 100644 > index 00000000000..3c0b8a82ab3 > --- /dev/null > +++ b/gcc/testsuite/gcc.dg/pr110947.c > @@ -0,0 +1,4 @@ > +/* { dg-do compile { target i?86-*-* x86_64-*-* } } */ > +/* { dg-options "-Wmissing-variable-declarations" } */ > + > +register unsigned long current_stack_pointer asm("rsp"); > -- > 2.41.0 >