From: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
To: Andrew Pinski <pinskia@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Richard Sandiford <Richard.Sandiford@arm.com>
Subject: Re: [PATCH] AArch64: Cleanup aarch64_classify_symbol
Date: Wed, 28 Apr 2021 20:34:50 +0000 [thread overview]
Message-ID: <VE1PR08MB55996D34A8527454B89E335883409@VE1PR08MB5599.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <CA+=Sn1mmBP_MwOWOUYJMoK9ZvX66fnw2xyD0Ps9R1bp=ZBt=1A@mail.gmail.com>
Hi Andrew,
> I thought that was changed not to use the GOT on purpose.
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63874
>
> That is if the symbol is not declared in the TU, then using the GOT is
> correct thing to do.
> Is the testcase gcc.target/aarch64/pr63874.c still working or is not
> testing the correct thing?
That PR was about weak definitions, not references. The exact same
sequence is emitted whether we use the GOT or literal (ADRP+LDR),
hence there is no point in treating the non-PIC case differently.
Cheers,
Wilco
prev parent reply other threads:[~2021-04-28 20:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-28 14:36 Wilco Dijkstra
2021-04-28 15:34 ` Richard Sandiford
2021-04-28 17:48 ` Wilco Dijkstra
2021-04-30 8:46 ` Richard Sandiford
2021-04-30 12:11 ` Wilco Dijkstra
2021-04-30 12:50 ` Richard Sandiford
2021-04-28 18:04 ` Andrew Pinski
2021-04-28 20:34 ` Wilco Dijkstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VE1PR08MB55996D34A8527454B89E335883409@VE1PR08MB5599.eurprd08.prod.outlook.com \
--to=wilco.dijkstra@arm.com \
--cc=Richard.Sandiford@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=pinskia@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).