From: Bernd Edlinger <bernd.edlinger@hotmail.de>
To: Richard Biener <rguenther@suse.de>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Avoid another non zero terminated string constant (revert)
Date: Fri, 14 Sep 2018 13:08:00 -0000 [thread overview]
Message-ID: <VI1PR0701MB28623C3A46CD323ACC0E5B04E4190@VI1PR0701MB2862.eurprd07.prod.outlook.com> (raw)
In-Reply-To: <alpine.LSU.2.20.1807300852460.16707@zhemvz.fhfr.qr>
[-- Attachment #1: Type: text/plain, Size: 1416 bytes --]
On 07/30/18 08:52, Richard Biener wrote:
> On Sun, 29 Jul 2018, Bernd Edlinger wrote:
>
>> Hi!
>>
>> This fixes another not NUL terminated string literal that is created
>> in tree-ssa-forwprop.c at simplify_builtin_call.
>>
>> src_buf is set up to contain a NUL at src_buf[src_len], thus use src_len + 1
>> as length parameter to build_string_literal. All other uses of
>> build_string_literal do it right, as far as I can see.
>>
>>
>> Bootstrapped and reg-tested on x86_64-pc-linux-gnu.
>> Is it OK for trunk?
>
> OK.
>
> Richard.
>
Hi,
when I installed that patch it appeared to me that naturally all string
constants ought to be zero-terminated.
But since we have now the STRING_CST semantic changes installed,
which do equally support both zero and non-zero terminated string constants,
I want to revert this again:
r263068 | edlinger | 2018-07-30 15:26:25 +0200 (Mo, 30. Jul 2018) | 5 Zeilen
Geänderte Pfade:
M /trunk/gcc/ChangeLog
M /trunk/gcc/tree-ssa-forwprop.c
2018-07-30 Bernd Edlinger <bernd.edlinger@hotmail.de>
* tree-ssa-forwprop.c (simplify_builtin_call): Don't create a not NUL
terminated string literal.
So unless there are reasons to keep this zero-terminated string constant,
I am going to revert this patch today evening, after another
Bootstrapped and reg-tested on x86_64-pc-linux-gnu.
Thanks
Bernd.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: patch-revert-r263068.diff --]
[-- Type: text/x-patch; name="patch-revert-r263068.diff", Size: 933 bytes --]
Index: gcc/ChangeLog
===================================================================
--- gcc/ChangeLog (revision 263068)
+++ gcc/ChangeLog (revision 263067)
@@ -1,8 +1,3 @@
-2018-07-30 Bernd Edlinger <bernd.edlinger@hotmail.de>
-
- * tree-ssa-forwprop.c (simplify_builtin_call): Don't create a not NUL
- terminated string literal.
-
2018-07-30 Segher Boessenkool <segher@kernel.crashing.org>
PR rtl-optimization/85160
Index: gcc/tree-ssa-forwprop.c
===================================================================
--- gcc/tree-ssa-forwprop.c (revision 263068)
+++ gcc/tree-ssa-forwprop.c (revision 263067)
@@ -1391,7 +1391,7 @@
src_buf, ptr1_align, false))
break;
- new_str_cst = build_string_literal (src_len + 1, src_buf);
+ new_str_cst = build_string_literal (src_len, src_buf);
if (callee1)
{
/* If STMT1 is a mem{,p}cpy call, adjust it and remove
prev parent reply other threads:[~2018-09-14 13:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-29 8:14 [PATCH] Avoid another non zero terminated string constant Bernd Edlinger
2018-07-30 6:52 ` Richard Biener
2018-09-14 13:08 ` Bernd Edlinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR0701MB28623C3A46CD323ACC0E5B04E4190@VI1PR0701MB2862.eurprd07.prod.outlook.com \
--to=bernd.edlinger@hotmail.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).