From: Bernd Edlinger <bernd.edlinger@hotmail.de>
To: Jason Merrill <jason@redhat.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Jeff Law <law@redhat.com>, Richard Biener <rguenther@suse.de>,
Joseph Myers <joseph@codesourcery.com>,
Martin Sebor <msebor@gmail.com>
Subject: Re: [PATCHv2] Call braced_list_to_string after array size is fixed
Date: Thu, 30 Aug 2018 07:07:00 -0000 [thread overview]
Message-ID: <VI1PR0701MB286258DC4EABA36438F6B238E4080@VI1PR0701MB2862.eurprd07.prod.outlook.com> (raw)
In-Reply-To: <d968746d-a3c5-2e11-5170-939dda30791c@redhat.com>
On 08/30/18 06:34, Jason Merrill wrote:
> On 08/24/2018 03:52 PM, Bernd Edlinger wrote:
>> this updated patch fixes one regression with current trunk due
>> to a new test case. Sorry for the confusion.
>>
>> The change to the previous version is:
>> 1) the check to avoid folding on empty char arrays is restored.
>> 2) A null-termination character is added except when the string is full length.
>
>> - && TYPE_STRING_FLAG (TREE_TYPE (valtype)))
>
>> + tree typ1 = TYPE_MAIN_VARIANT (TREE_TYPE (type));
>> + if (typ1 == char_type_node
>> + || typ1 == signed_char_type_node
>> + || typ1 == unsigned_char_type_node)
>
>
> Why stop using TYPE_STRING_FLAG?
>
No longer sure, I will try it with TYPE_STRING_FLAG.
Bernd.
next prev parent reply other threads:[~2018-08-30 7:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-17 12:01 [PATCH] " Bernd Edlinger
2018-08-22 13:18 ` Bernd Edlinger
2018-08-24 19:52 ` [PATCHv2] " Bernd Edlinger
2018-08-26 3:34 ` Jeff Law
2018-08-26 7:46 ` Bernd Edlinger
2018-08-31 16:45 ` Jeff Law
2018-08-31 17:38 ` Bernd Edlinger
2018-08-30 4:34 ` Jason Merrill
2018-08-30 7:07 ` Bernd Edlinger [this message]
2018-08-31 6:47 ` Bernd Edlinger
2018-09-02 15:19 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR0701MB286258DC4EABA36438F6B238E4080@VI1PR0701MB2862.eurprd07.prod.outlook.com \
--to=bernd.edlinger@hotmail.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
--cc=joseph@codesourcery.com \
--cc=law@redhat.com \
--cc=msebor@gmail.com \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).