From: Tamar Christina <Tamar.Christina@arm.com>
To: GCC Patches <gcc-patches@gcc.gnu.org>
Cc: nd <nd@arm.com>, Kyrylo Tkachov <Kyrylo.Tkachov@arm.com>,
Richard Earnshaw <Richard.Earnshaw@arm.com>,
Ramana Radhakrishnan <Ramana.Radhakrishnan@arm.com>
Subject: Re: [GCC][PATCH][ARM][Committed] Disable sdiv_1 test on softfloat targets.
Date: Mon, 12 Jun 2017 13:27:00 -0000 [thread overview]
Message-ID: <VI1PR0801MB20314B8E9125B3ECB54CF604FFCD0@VI1PR0801MB2031.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <VI1PR0801MB20313DBE70212BD79BC2D498FFCD0@VI1PR0801MB2031.eurprd08.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 993 bytes --]
Committed a less restrictive form in r249125 which now just requires arm_v8_vfp_ok
gcc/testsuite/
2017-06-12 Tamar Christina <tamar.christina@arm.com>
* gcc.target/arm/sdiv_costs_1.c: Require arm_v8_vfp_ok.
Thanks,
Tamar
________________________________________
From: gcc-patches-owner@gcc.gnu.org <gcc-patches-owner@gcc.gnu.org> on behalf of Tamar Christina <Tamar.Christina@arm.com>
Sent: Monday, June 12, 2017 1:35:08 PM
To: GCC Patches
Cc: nd; Kyrylo Tkachov; Richard Earnshaw; Ramana Radhakrishnan
Subject: [GCC][PATCH][ARM][Committed] Disable sdiv_1 test on softfloat targets.
Hi All,
I committed this as r249122 under the GCC obvious rule.
This fixes the failing test gcc.target/arm/sdiv_costs_1.c on soft float targets
by disabling it on those targets since the div calls aren't expanded.
gcc/testsuite/
2017-06-12 Tamar Christina <tamar.christina@arm.com>
* gcc.target/arm/sdiv_costs_1.c: Disable on softfloat.
Thanks,
Tamar
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: sdiv-arm-fix-2.patch --]
[-- Type: text/x-patch; name="sdiv-arm-fix-2.patch", Size: 555 bytes --]
diff --git a/gcc/testsuite/gcc.target/arm/sdiv_costs_1.c b/gcc/testsuite/gcc.target/arm/sdiv_costs_1.c
index 76086ab9ce28fceb37a4e8a615a38923fa7b985a..3920590dfcce975aaf7cbe7a4d056df203b7ca2e 100644
--- a/gcc/testsuite/gcc.target/arm/sdiv_costs_1.c
+++ b/gcc/testsuite/gcc.target/arm/sdiv_costs_1.c
@@ -1,5 +1,6 @@
/* { dg-do compile } */
-/* { dg-options "-O3 -march=armv8-a" } */
+/* { dg-options "-O3" } */
+/* { dg-require-effective-target arm_v8_vfp_ok } */
/* Both sdiv and udiv can be used here, so prefer udiv. */
int f1 (unsigned char *p)
next prev parent reply other threads:[~2017-06-12 13:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-12 12:35 Tamar Christina
2017-06-12 13:27 ` Tamar Christina [this message]
2017-06-13 7:57 ` Christophe Lyon
2017-06-13 8:31 ` Tamar Christina
2017-06-13 8:41 ` Christophe Lyon
2017-06-13 10:10 ` Tamar Christina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR0801MB20314B8E9125B3ECB54CF604FFCD0@VI1PR0801MB2031.eurprd08.prod.outlook.com \
--to=tamar.christina@arm.com \
--cc=Kyrylo.Tkachov@arm.com \
--cc=Ramana.Radhakrishnan@arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).