* [GCC][PATCH][ARM] Require arm_arch_v8a_ok for sdiv_costs_1.c
@ 2017-06-13 10:12 Tamar Christina
2017-06-13 10:13 ` Kyrill Tkachov
0 siblings, 1 reply; 4+ messages in thread
From: Tamar Christina @ 2017-06-13 10:12 UTC (permalink / raw)
To: GCC Patches
Cc: nd, Christophe Lyon, Kyrylo Tkachov, Ramana Radhakrishnan,
Richard Earnshaw
[-- Attachment #1: Type: text/plain, Size: 295 bytes --]
Hi All,
This fixes the failing test gcc.target/arm/sdiv_costs_1.c by
requiring arm_arch_v8a_ok.
OK for trunk?
gcc/testsuite/
2017-06-13 Tamar Christina <tamar.christina@arm.com>
* gcc.target/arm/sdiv_costs_1.c:
Require arm_arch_v8a_ok and add march option.
Thanks,
Tamar
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: sdiv-armv8.patch --]
[-- Type: text/x-patch; name="sdiv-armv8.patch", Size: 610 bytes --]
diff --git a/gcc/testsuite/gcc.target/arm/sdiv_costs_1.c b/gcc/testsuite/gcc.target/arm/sdiv_costs_1.c
index 3920590dfcce975aaf7cbe7a4d056df203b7ca2e..9d094ac0c1d12193e8db82120d266bae5b5bf297 100644
--- a/gcc/testsuite/gcc.target/arm/sdiv_costs_1.c
+++ b/gcc/testsuite/gcc.target/arm/sdiv_costs_1.c
@@ -1,6 +1,6 @@
/* { dg-do compile } */
-/* { dg-options "-O3" } */
-/* { dg-require-effective-target arm_v8_vfp_ok } */
+/* { dg-options "-O3 -march=armv8-a" } */
+/* { dg-require-effective-target arm_arch_v8a_ok } */
/* Both sdiv and udiv can be used here, so prefer udiv. */
int f1 (unsigned char *p)
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [GCC][PATCH][ARM] Require arm_arch_v8a_ok for sdiv_costs_1.c
2017-06-13 10:12 [GCC][PATCH][ARM] Require arm_arch_v8a_ok for sdiv_costs_1.c Tamar Christina
@ 2017-06-13 10:13 ` Kyrill Tkachov
2017-06-13 12:24 ` Christophe Lyon
0 siblings, 1 reply; 4+ messages in thread
From: Kyrill Tkachov @ 2017-06-13 10:13 UTC (permalink / raw)
To: Tamar Christina, GCC Patches
Cc: nd, Christophe Lyon, Ramana Radhakrishnan, Richard Earnshaw
On 13/06/17 11:12, Tamar Christina wrote:
> Hi All,
>
> This fixes the failing test gcc.target/arm/sdiv_costs_1.c by
> requiring arm_arch_v8a_ok.
>
>
> OK for trunk?
>
Ok.
Thanks,
Kyrill
> gcc/testsuite/
> 2017-06-13 Tamar Christina <tamar.christina@arm.com>
>
> * gcc.target/arm/sdiv_costs_1.c:
> Require arm_arch_v8a_ok and add march option.
>
> Thanks,
> Tamar
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [GCC][PATCH][ARM] Require arm_arch_v8a_ok for sdiv_costs_1.c
2017-06-13 10:13 ` Kyrill Tkachov
@ 2017-06-13 12:24 ` Christophe Lyon
2017-06-15 9:26 ` Tamar Christina
0 siblings, 1 reply; 4+ messages in thread
From: Christophe Lyon @ 2017-06-13 12:24 UTC (permalink / raw)
To: Kyrill Tkachov
Cc: Tamar Christina, GCC Patches, nd, Ramana Radhakrishnan, Richard Earnshaw
On 13 June 2017 at 12:13, Kyrill Tkachov <kyrylo.tkachov@foss.arm.com> wrote:
>
> On 13/06/17 11:12, Tamar Christina wrote:
>>
>> Hi All,
>>
>> This fixes the failing test gcc.target/arm/sdiv_costs_1.c by
>> requiring arm_arch_v8a_ok.
>>
>>
>> OK for trunk?
>>
>
> Ok.
> Thanks,
> Kyrill
>
>
>> gcc/testsuite/
>> 2017-06-13 Tamar Christina <tamar.christina@arm.com>
>>
>> * gcc.target/arm/sdiv_costs_1.c:
>> Require arm_arch_v8a_ok and add march option.
>>
Shouldn't you use
add_options_for_arm_arch_v8a instead?
>> Thanks,
>> Tamar
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [GCC][PATCH][ARM] Require arm_arch_v8a_ok for sdiv_costs_1.c
2017-06-13 12:24 ` Christophe Lyon
@ 2017-06-15 9:26 ` Tamar Christina
0 siblings, 0 replies; 4+ messages in thread
From: Tamar Christina @ 2017-06-15 9:26 UTC (permalink / raw)
To: Christophe Lyon, Kyrill Tkachov
Cc: GCC Patches, nd, Ramana Radhakrishnan, Richard Earnshaw
> >> * gcc.target/arm/sdiv_costs_1.c:
> >> Require arm_arch_v8a_ok and add march option.
> >>
>
> Shouldn't you use
> add_options_for_arm_arch_v8a instead?
Done, committed as r249214.
I don't quite understand the difference, but this test suite does quite
counter intuitive things.
>
> >> Thanks,
> >> Tamar
> >
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-06-15 9:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-13 10:12 [GCC][PATCH][ARM] Require arm_arch_v8a_ok for sdiv_costs_1.c Tamar Christina
2017-06-13 10:13 ` Kyrill Tkachov
2017-06-13 12:24 ` Christophe Lyon
2017-06-15 9:26 ` Tamar Christina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).