From: Tamar Christina <Tamar.Christina@arm.com>
To: Tom de Vries <Tom_deVries@mentor.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Cc: nd <nd@arm.com>
Subject: RE: [PATCH, PR77558] Remove RECORD_TYPE special-casing in std_canonical_va_list_type
Date: Fri, 07 Oct 2016 15:25:00 -0000 [thread overview]
Message-ID: <VI1PR0801MB20319446EEDFA11B922CCA5EFFC60@VI1PR0801MB2031.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <2908590d-f799-7053-9f52-2f0b65803c4e@mentor.com>
Ping?
Would be great to get this in, it's currently showing up as a major issue on our nightlies.
Cheers,
Tamar
> -----Original Message-----
> From: gcc-patches-owner@gcc.gnu.org [mailto:gcc-patches-
> owner@gcc.gnu.org] On Behalf Of Tom de Vries
> Sent: 25 September 2016 10:08
> To: GCC Patches
> Subject: [PATCH, PR77558] Remove RECORD_TYPE special-casing in
> std_canonical_va_list_type
>
> Hi,
>
> this patch fixes PR77558, an ice-on-invalid-code 6/7 regression.
>
> The fix for PR71602 introduced the invalid-code test-case
> c-c++-common/va-arg-va-list-type.c:
> ...
> __builtin_va_list *pap;
>
> void
> fn1 (void)
> {
> __builtin_va_arg (pap, double); /* { dg-error "first argument to 'va_arg' not
> of type 'va_list'" } */ } ...
>
> The test-case passes for x86_64, but fails for aarch64 and ICEs for arm.
>
> The ICE happens because the patch for PR71602 is incomplete. The patch
> tries to be more strict about returning a canonical va_list only for actual
> va_lists, but doesn't implement this for structure va_list types, such as we
> have for arm, aarch64 and alpha.
>
> This patch adds the missing part, and fixes the ICE.
>
> OK for trunk, 6-branch?
>
> Thanks,
> - Tom
next prev parent reply other threads:[~2016-10-07 15:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-25 13:00 Tom de Vries
2016-10-07 15:25 ` Tamar Christina [this message]
2016-10-10 9:54 ` Richard Biener
2016-10-11 12:01 ` Christophe Lyon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR0801MB20319446EEDFA11B922CCA5EFFC60@VI1PR0801MB2031.eurprd08.prod.outlook.com \
--to=tamar.christina@arm.com \
--cc=Tom_deVries@mentor.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).