From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 46874 invoked by alias); 12 Dec 2016 09:20:04 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 46855 invoked by uid 89); 12 Dec 2016 09:20:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL,BAYES_00,KAM_ASCII_DIVIDERS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS,URIBL_RED autolearn=no version=3.3.2 spammy=capital, Infinite, Hx-spam-relays-external:15.01.0761.021, H*RU:sk:mail-ve X-HELO: EUR01-VE1-obe.outbound.protection.outlook.com Received: from mail-ve1eur01on0077.outbound.protection.outlook.com (HELO EUR01-VE1-obe.outbound.protection.outlook.com) (104.47.1.77) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 12 Dec 2016 09:19:53 +0000 Received: from VI1PR0801MB2031.eurprd08.prod.outlook.com (10.173.74.140) by AM5PR0802MB2609.eurprd08.prod.outlook.com (10.175.46.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.771.8; Mon, 12 Dec 2016 09:19:50 +0000 Received: from VI1PR0801MB2031.eurprd08.prod.outlook.com ([10.173.74.140]) by VI1PR0801MB2031.eurprd08.prod.outlook.com ([10.173.74.140]) with mapi id 15.01.0761.021; Mon, 12 Dec 2016 09:19:49 +0000 From: Tamar Christina To: Joseph Myers CC: GCC Patches , Wilco Dijkstra , "rguenther@suse.de" , "law@redhat.com" , Michael Meissner , nd Subject: Re: [PATCH][GCC][PATCHv3] Improve fpclassify w.r.t IEEE like numbers in GIMPLE. Date: Mon, 12 Dec 2016 09:20:00 -0000 Message-ID: References: , ,,, In-Reply-To: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Tamar.Christina@arm.com; x-ms-exchange-messagesentrepresentingtype: 1 x-ms-office365-filtering-correlation-id: 050c7821-bf36-4848-cbc9-08d4227005cb x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:AM5PR0802MB2609; x-microsoft-exchange-diagnostics: 1;AM5PR0802MB2609;7:/xcu8Lpo4KL+gRfz3X9jb2LjuSjtfemyrHNcjo8Kuz3v3O5MOs+0Azt+VHaJKRKsOl5v26GUjrfddKPn/PydobR+2AE/9SNFK0jALGvieUb/CvLP3dEAEQehkezrlToivZ1uJ97EGX4dSNV5AbxOHXGRcVSKRvz0OfuKbdGtihfGeH5vugehpq8EQdBfshrY+tNq9gm5oacL7tvzd3eob7LmllV4emfgf1g7D/yuobz+DWtwfn7iYRrXUceCoUDmdswPz7ajsLQ3inGpUm6aTlaG83xVXuI6OLZKdJFwMtUZZP6i6Q2s8IszjwMLRTkdyKB+jEc2r/+iZA/cShFdoES5A1A0RtgOfz3OHBM3AshpcK7APd0/whMcdgls404VjaQNmtEcUxeGOBn7EgcHnVrlO1d3eyPaLE3xT2YWuwOcWB6oyDFL5AgVyjiOGcXrbzMfXcLu3CTApIIOtdiRew== nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026)(6041248)(20161123555025)(20161123560025)(20161123564025)(20161123562025)(6072148);SRVR:AM5PR0802MB2609;BCL:0;PCL:0;RULEID:;SRVR:AM5PR0802MB2609; x-forefront-prvs: 0154C61618 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(7916002)(39850400002)(39410400002)(39450400003)(39840400002)(377454003)(189002)(199003)(24454002)(6916009)(5660300001)(92566002)(50986999)(6436002)(4326007)(229853002)(97736004)(76176999)(93886004)(54356999)(101416001)(81156014)(8676002)(86362001)(2900100001)(66066001)(8936002)(9686002)(76576001)(81166006)(102836003)(189998001)(3660700001)(33656002)(3846002)(2906002)(6506006)(106356001)(305945005)(110136003)(7736002)(7696004)(106116001)(38730400001)(74316002)(6116002)(68736007)(3280700002)(122556002)(105586002)(2950100002)(77096006);DIR:OUT;SFP:1101;SCL:1;SRVR:AM5PR0802MB2609;H:VI1PR0801MB2031.eurprd08.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Dec 2016 09:19:49.1513 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0802MB2609 X-IsSubscribed: yes X-SW-Source: 2016-12/txt/msg00990.txt.bz2 Ping ________________________________________ From: Tamar Christina Sent: Friday, December 2, 2016 4:20:42 PM To: Joseph Myers Cc: GCC Patches; Wilco Dijkstra; rguenther@suse.de; law@redhat.com; Michael= Meissner; nd Subject: Re: [PATCH][GCC][PATCHv3] Improve fpclassify w.r.t IEEE like numbe= rs in GIMPLE. Ping? Is there anything else I need to do for the patch or is it OK for trunk? Thanks, Tamar ________________________________________ From: Tamar Christina Sent: Friday, November 25, 2016 12:18:52 PM To: Joseph Myers Cc: GCC Patches; Wilco Dijkstra; rguenther@suse.de; law@redhat.com; Michael= Meissner; nd Subject: Re: [PATCH][GCC][PATCHv3] Improve fpclassify w.r.t IEEE like numbe= rs in GIMPLE. Hi Joseph, I have updated the patch with the changes, w.r.t to the formatting, there are tabs there that seem to be rendered at 4 spaces wide. In my editor setup at 8 spaces they are correct. Kind Regards, Tamar ________________________________________ From: Joseph Myers Sent: Thursday, November 24, 2016 6:28:18 PM To: Tamar Christina Cc: GCC Patches; Wilco Dijkstra; rguenther@suse.de; law@redhat.com; Michael= Meissner; nd Subject: Re: [PATCH][GCC][PATCHv3] Improve fpclassify w.r.t IEEE like numbe= rs in GIMPLE. On Thu, 24 Nov 2016, Tamar Christina wrote: > @@ -11499,6 +11503,53 @@ to classify. GCC treats the last argument as ty= pe-generic, which > means it does not do default promotion from float to double. > @end deftypefn > > +@deftypefn {Built-in Function} int __builtin_isnan (...) > +This built-in implements the C99 isnan functionality which checks if > +the given argument represents a NaN. The return value of the > +function will either be a 0 (false) or a 1 (true). > +On most systems, when an IEEE 754 floating point is used this > +built-in does not produce a signal when a signaling NaN is used. "an IEEE 754 floating point" should probably be "an IEEE 754 floating-point type" or similar. > +GCC treats the argument as type-generic, which means it does > +not do default promotion from float to double. I think type names such as float and double should use @code{} in the manual. > +the given argument represents an Infinite number. The return Infinite should not have a capital letter there. > +@deftypefn {Built-in Function} int __builtin_iszero (...) > +This built-in implements the C99 iszero functionality which checks if This isn't C99, it's TS 18661-1:2014. > +the given argument represents the number 0. The return 0 or -0. > +@deftypefn {Built-in Function} int __builtin_issubnormal (...) > +This built-in implements the C99 issubnormal functionality which checks = if Again, TS 18661-1. > +the given argument represents a sub-normal number. The return Do not hyphenate subnormal. > + switch (DECL_FUNCTION_CODE (decl)) > + { > + case BUILT_IN_SETJMP: > + lower_builtin_setjmp (gsi); > + data->cannot_fallthru =3D false; > + return; The indentation in this whole block of code (not all quoted) is wrong. > + real_inf(&rinf); Missing space before '('. > + emit_tree_cond (&body, dest, done_label, > + is_normal(&body, arg, loc), fp_normal); > + emit_tree_cond (&body, dest, done_label, > + is_zero(&body, arg, loc), fp_zero); > + emit_tree_cond (&body, dest, done_label, > + is_nan(&body, arg, loc), fp_nan); > + emit_tree_cond (&body, dest, done_label, > + is_infinity(&body, arg, loc), fp_infinite); Likewise. > + fndecl(&body, arg, loc), t_true); Likewise. -- Joseph S. Myers joseph@codesourcery.com