From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 78558 invoked by alias); 7 Jun 2017 15:09:59 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 76887 invoked by uid 89); 7 Jun 2017 15:09:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_LOTSOFHASH,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: EUR01-VE1-obe.outbound.protection.outlook.com Received: from mail-ve1eur01on0040.outbound.protection.outlook.com (HELO EUR01-VE1-obe.outbound.protection.outlook.com) (104.47.1.40) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 07 Jun 2017 15:09:54 +0000 Received: from VI1PR0801MB2031.eurprd08.prod.outlook.com (10.173.74.140) by HE1PR0802MB2393.eurprd08.prod.outlook.com (10.175.33.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1143.10; Wed, 7 Jun 2017 15:09:48 +0000 Received: from VI1PR0801MB2031.eurprd08.prod.outlook.com ([fe80::b9d4:b6e7:35f9:e399]) by VI1PR0801MB2031.eurprd08.prod.outlook.com ([fe80::b9d4:b6e7:35f9:e399%17]) with mapi id 15.01.1143.018; Wed, 7 Jun 2017 15:09:47 +0000 From: Tamar Christina To: Kyrill Tkachov , GCC Patches CC: nd , Ramana Radhakrishnan , Richard Earnshaw , "nickc@redhat.com" Subject: Re: [PATCH][GCC][ARM] Adjust costs so udiv is preferred over sdiv when both are valid. [Patch (2/2)] Date: Wed, 07 Jun 2017 15:09:00 -0000 Message-ID: References: <5937CF90.9040506@foss.arm.com>, In-Reply-To: authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;HE1PR0802MB2393;7:xa+9plzwwnPxsyNZmGNtNeuaLwrQBrGNh1LtjlrKEwJPsriUdahECgYO1trPcAoKCVjRVU/7VMjb1N6WPbbhuHgpAyzvNcjtxMhFItxYxClbShWjYsVtjtqzz3lIVVOzliEEthTR6176N0WyihItv11Sx4Vmpj2AgcL45oVyLbg7F+Cv4qoTjwds39OJjOJrRjMHXBFmq6Al4k4vgtJ5ZF9vrKO/vKb9lE6k9IBrS/kGuJOjNp5AQwlciLPCszVJRGLXNlXCOurxfmix5wjtgL5TkXdwjQklN8O37hg8josAXOHDH+F8l5G3VkbsdBTnauMAm2/m12N7/Oh523tm2g== x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-ms-traffictypediagnostic: HE1PR0802MB2393: x-ms-office365-filtering-correlation-id: e21e3d1c-ab4a-4a05-f15e-08d4adb73cdd x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081);SRVR:HE1PR0802MB2393; nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(102415395)(6040450)(601004)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(3002001)(10201501046)(93006095)(93001095)(6055026)(6041248)(20161123562025)(20161123555025)(20161123560025)(20161123564025)(201703131423075)(201703011903075)(201702281528075)(201703061421075)(20161123558100)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:HE1PR0802MB2393;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:HE1PR0802MB2393; x-forefront-prvs: 03319F6FEF x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(39850400002)(39410400002)(39400400002)(39860400002)(39450400003)(377454003)(508600001)(99936001)(54356999)(76176999)(50986999)(5250100002)(86362001)(33656002)(575784001)(81166006)(8936002)(2906002)(229853002)(189998001)(6116002)(3280700002)(3660700001)(66066001)(2900100001)(102836003)(4326008)(3846002)(53546009)(25786009)(14454004)(72206003)(9686003)(5660300001)(7736002)(6436002)(6506006)(99286003)(38730400002)(74316002)(54906002)(55016002)(53936002)(2950100002)(305945005)(6246003)(7696004);DIR:OUT;SFP:1101;SCL:1;SRVR:HE1PR0802MB2393;H:VI1PR0801MB2031.eurprd08.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: multipart/mixed; boundary="_002_VI1PR0801MB2031ED2A6A0DFD3521C695DEFFC80VI1PR0801MB2031_" MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jun 2017 15:09:47.7099 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0802MB2393 X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg00441.txt.bz2 --_002_VI1PR0801MB2031ED2A6A0DFD3521C695DEFFC80VI1PR0801MB2031_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-length: 2081 Hi Kyrill, I have updated the patch and regtested on arm-none-linux-gnueabihf. OK for trunk? Thanks, Tamar ________________________________________ From: Tamar Christina Sent: Wednesday, June 7, 2017 11:15:49 AM To: Kyrill Tkachov; GCC Patches Cc: nd; Ramana Radhakrishnan; Richard Earnshaw; nickc@redhat.com Subject: RE: [PATCH][GCC][ARM] Adjust costs so udiv is preferred over sdiv = when both are valid. [Patch (2/2)] Hi Kyrill, > diff --git a/gcc/config/arm/arm.c b/gcc/config/arm/arm.c index > b24143e32e2f100000f3b150f7ed0df4fabb3cc8..ecc7688b1db6309a4dd694a8e > 254e64abe14d7e3 100644 > --- a/gcc/config/arm/arm.c > +++ b/gcc/config/arm/arm.c > @@ -9258,6 +9258,8 @@ arm_rtx_costs_internal (rtx x, enum rtx_code > code, enum rtx_code outer_code, > *cost +=3D COSTS_N_INSNS (speed_p ? extra_cost->mult[0].idiv : 0); > else > *cost =3D LIBCALL_COST (2); > + > + *cost +=3D (code =3D=3D DIV ? 1 : 0); > return false; /* All arguments must be in registers. */ > > > We usually try to avoid adjusting the costs in units other than > COSTS_N_INSNS. > Would adding COSTS_N_INSNS (1) here work? > If so, could you also add a comment here to describe why we're adjusting = the > cost. It would, I'm just slightly worried it might end up generating different co= de for DIV then. The reason I have used a unit smaller than COSTS_N_INSNS it so that it shou= ld have any real Impact on any other optimization as the cost is likely treated as an intege= r? It's only for things that Compare the costs values between signed and unsigned would the small unit m= ake a difference. Since I think the compiler still has some hard coded cost limits somewhere = it may be an issue, but I'm not 100% certain. I can make the change though. > > case MOD: > @@ -9280,7 +9282,7 @@ arm_rtx_costs_internal (rtx x, enum rtx_code > code, enum rtx_code outer_code, > > /* Fall-through. */ > case UMOD: > - *cost =3D LIBCALL_COST (2); > + *cost =3D LIBCALL_COST (2) + (code =3D=3D MOD ? 1 : 0); > > Same here. > > Thanks, > Kyrill > --_002_VI1PR0801MB2031ED2A6A0DFD3521C695DEFFC80VI1PR0801MB2031_ Content-Type: text/x-patch; name="arm-div-costs.patch" Content-Description: arm-div-costs.patch Content-Disposition: attachment; filename="arm-div-costs.patch"; size=2167; creation-date="Wed, 07 Jun 2017 15:04:22 GMT"; modification-date="Wed, 07 Jun 2017 15:04:22 GMT" Content-Transfer-Encoding: base64 Content-length: 2941 ZGlmZiAtLWdpdCBhL2djYy9jb25maWcvYXJtL2FybS5jIGIvZ2NjL2NvbmZp Zy9hcm0vYXJtLmMKaW5kZXggYjI0MTQzZTMyZTJmMTAwMDAwZjNiMTUwZjdl ZDBkZjRmYWJiM2NjOC4uNDQyZDEyZGU0ZGNmZjUwNDg0MjI5ZTJkMjdlNjVk NzhjM2ZkNmIzNyAxMDA2NDQKLS0tIGEvZ2NjL2NvbmZpZy9hcm0vYXJtLmMK KysrIGIvZ2NjL2NvbmZpZy9hcm0vYXJtLmMKQEAgLTkyNTgsNiArOTI1OCwx MCBAQCBhcm1fcnR4X2Nvc3RzX2ludGVybmFsIChydHggeCwgZW51bSBydHhf Y29kZSBjb2RlLCBlbnVtIHJ0eF9jb2RlIG91dGVyX2NvZGUsCiAJKmNvc3Qg Kz0gQ09TVFNfTl9JTlNOUyAoc3BlZWRfcCA/IGV4dHJhX2Nvc3QtPm11bHRb MF0uaWRpdiA6IDApOwogICAgICAgZWxzZQogCSpjb3N0ID0gTElCQ0FMTF9D T1NUICgyKTsKKworICAgICAgLyogTWFrZSB0aGUgY29zdCBvZiBzZGl2IG1v cmUgZXhwZW5zaXZlIHNvIHdoZW4gYm90aCBzZGl2IGFuZCB1ZGl2IGFyZQor CSBwb3NzaWJsZSB1ZGl2IGlzIHByZWZlcmVkLiAgKi8KKyAgICAgICpjb3N0 ICs9IChjb2RlID09IERJViA/IENPU1RTX05fSU5TTlMgKDEpIDogMCk7CiAg ICAgICByZXR1cm4gZmFsc2U7CS8qIEFsbCBhcmd1bWVudHMgbXVzdCBiZSBp biByZWdpc3RlcnMuICAqLwogCiAgICAgY2FzZSBNT0Q6CkBAIC05MjgwLDcg KzkyODQsOSBAQCBhcm1fcnR4X2Nvc3RzX2ludGVybmFsIChydHggeCwgZW51 bSBydHhfY29kZSBjb2RlLCBlbnVtIHJ0eF9jb2RlIG91dGVyX2NvZGUsCiAK ICAgICAvKiBGYWxsLXRocm91Z2guICAqLwogICAgIGNhc2UgVU1PRDoKLSAg ICAgICpjb3N0ID0gTElCQ0FMTF9DT1NUICgyKTsKKyAgICAgIC8qIE1ha2Ug dGhlIGNvc3Qgb2Ygc2RpdiBtb3JlIGV4cGVuc2l2ZSBzbyB3aGVuIGJvdGgg c2RpdiBhbmQgdWRpdiBhcmUKKwkgcG9zc2libGUgdWRpdiBpcyBwcmVmZXJl ZC4gICovCisgICAgICAqY29zdCA9IExJQkNBTExfQ09TVCAoMikgKyAoY29k ZSA9PSBNT0QgPyBDT1NUU19OX0lOU05TICgxKSA6IDApOwogICAgICAgcmV0 dXJuIGZhbHNlOwkvKiBBbGwgYXJndW1lbnRzIG11c3QgYmUgaW4gcmVnaXN0 ZXJzLiAgKi8KIAogICAgIGNhc2UgUk9UQVRFOgpkaWZmIC0tZ2l0IGEvZ2Nj L3Rlc3RzdWl0ZS9nY2MudGFyZ2V0L2FybS9zZGl2X2Nvc3RzXzEuYyBiL2dj Yy90ZXN0c3VpdGUvZ2NjLnRhcmdldC9hcm0vc2Rpdl9jb3N0c18xLmMKbmV3 IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMC4uNzYwODZhYjljZTI4ZmNlYjM3YTRlOGE2 MTVhMzg5MjNmYTdiOTg1YQotLS0gL2Rldi9udWxsCisrKyBiL2djYy90ZXN0 c3VpdGUvZ2NjLnRhcmdldC9hcm0vc2Rpdl9jb3N0c18xLmMKQEAgLTAsMCAr MSwzOCBAQAorLyogeyBkZy1kbyBjb21waWxlIH0gKi8KKy8qIHsgZGctb3B0 aW9ucyAiLU8zIC1tYXJjaD1hcm12OC1hIiB9ICovCisKKy8qIEJvdGggc2Rp diBhbmQgdWRpdiBjYW4gYmUgdXNlZCBoZXJlLCBzbyBwcmVmZXIgdWRpdi4g ICovCitpbnQgZjEgKHVuc2lnbmVkIGNoYXIgKnApCit7CisgIHJldHVybiAx MDAgLyBwWzFdOworfQorCitpbnQgZjIgKHVuc2lnbmVkIGNoYXIgKnAsIHVu c2lnbmVkIHNob3J0IHgpCit7CisgIHJldHVybiB4IC8gcFswXTsKK30KKwor aW50IGYzICh1bnNpZ25lZCBjaGFyICpwLCBpbnQgeCkKK3sKKyAgeCAmPSAw eDdmZmZmZmZmOworICByZXR1cm4geCAvIHBbMF07Cit9CisKK2ludCBmNSAo dW5zaWduZWQgY2hhciAqcCwgdW5zaWduZWQgc2hvcnQgeCkKK3sKKyAgcmV0 dXJuIHggJSBwWzBdOworfQorCisvKiBUaGlzIHNob3VsZCBvbmx5IGdlbmVy YXRlIHNpZ25lZCBkaXZpc2lvbnMuICAqLworaW50IGY0ICh1bnNpZ25lZCBj aGFyICpwKQoreworICByZXR1cm4gLTEwMCAvIHBbMV07Cit9CisKK2ludCBm NiAodW5zaWduZWQgY2hhciAqcCwgc2hvcnQgeCkKK3sKKyAgcmV0dXJuIHgg JSBwWzBdOworfQorCisvKiB7IGRnLWZpbmFsIHsgc2Nhbi1hc3NlbWJsZXIt dGltZXMgInVkaXZcdHJcWzAtOVxdKywgclxbMC05XF0rLCByXFswLTlcXSsi IDQgfSB9ICovCisvKiB7IGRnLWZpbmFsIHsgc2Nhbi1hc3NlbWJsZXItdGlt ZXMgInNkaXZcdHJcWzAtOVxdKywgclxbMC05XF0rLCByXFswLTlcXSsiIDIg fSB9ICovCg== --_002_VI1PR0801MB2031ED2A6A0DFD3521C695DEFFC80VI1PR0801MB2031_--