From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 33779 invoked by alias); 9 Sep 2019 17:03:04 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 33757 invoked by uid 89); 9 Sep 2019 17:03:03 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-19.2 required=5.0 tests=AWL,BAYES_00,FORGED_SPF_HELO,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: EUR03-VE1-obe.outbound.protection.outlook.com Received: from mail-eopbgr50085.outbound.protection.outlook.com (HELO EUR03-VE1-obe.outbound.protection.outlook.com) (40.107.5.85) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 09 Sep 2019 17:03:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RQa7aNvl9RxtkoDSFUXBMLQ3F95w7FMFx+265UkP3gc=; b=gwFo3BOa2xyfmkzAxTcPbfanrBvX/WQSHLfQrG2eZzNFtt4A2L1UB73LGDEFGMeUvwqX41xxuWJNJfsCbjwMMdEsXvAOEgFBc0gOH/FKkLR6Wa+PXLA5LnZM20VQpiCZD4zgIN5pLhMuUTlmYL7eZdHEaxVmA202lR+sRJzBq8U= Received: from AM4PR08CA0043.eurprd08.prod.outlook.com (2603:10a6:205:2::14) by VE1PR08MB5037.eurprd08.prod.outlook.com (2603:10a6:803:115::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2241.18; Mon, 9 Sep 2019 17:02:56 +0000 Received: from VE1EUR03FT042.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e09::209) by AM4PR08CA0043.outlook.office365.com (2603:10a6:205:2::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2241.13 via Frontend Transport; Mon, 9 Sep 2019 17:02:56 +0000 Authentication-Results: spf=temperror (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; gcc.gnu.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;gcc.gnu.org; dmarc=temperror action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT042.mail.protection.outlook.com (10.152.19.62) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2241.14 via Frontend Transport; Mon, 9 Sep 2019 17:02:54 +0000 Received: ("Tessian outbound 6c75c202b9e0:v28"); Mon, 09 Sep 2019 17:02:54 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 078cd222ca0799d8 X-CR-MTA-TID: 64aa7808 Received: from c1056963bb71.2 (ip-172-16-0-2.eu-west-1.compute.internal [104.47.1.59]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id EAECF60B-1481-4F68-B22B-681B7F6BB683.1; Mon, 09 Sep 2019 17:02:49 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01lp2059.outbound.protection.outlook.com [104.47.1.59]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c1056963bb71.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384); Mon, 09 Sep 2019 17:02:49 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d+P2RjKRnHcTlm1Tjl9YK7TvMVG7Bo4/hFNWLiAfIqeZXMBDPqrdxKPxq7LvXVa15uL1H8D4e6Vx2vMxHxv+Zn4l+ULdwLNR/nboj4Cdm3Xc1m39Cm33lWerqZmEz6KAAXtDHbM3/uqroR5N3KmUp8ns8Z155i+jYuegRyuIu2aam1+5PNzhWkLN1MnwjiV6Pr5VCaRr94M/ZxtdL6br+ypBw15jyPEccpg2WNk0HXmbQudmEicPhGCNjbapcGYLw67EigX2e5O5+2xU+tX/V7r9H66xMuqyo8z61gsdOJuHw1s282xNYPYL9/JfW1IPJiKbsUsQ4OqdHn0jY1TZng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RQa7aNvl9RxtkoDSFUXBMLQ3F95w7FMFx+265UkP3gc=; b=KsZsT7PaRkzNArfy20dVnba1V1rVOw3wu05AE0O297DLga3hbGRFXm4me+n3nhyOt/jaDX+RfrHZqNBR/Xw2fc/HbXIvHT5YcjqRtBPhWbdfICkCJZrfrT8j/cbhLFYKvGXt5EbvWXWEWWF85pDX+yA2RmMH0GZfiO3LYfJwvx24rrmLph+dw5LSvtN2vNI1BGsWDc/JjLXkpcqkeWDNPRgAFrEVcqMmVpfwyDNvtAe/pINRNU++vKn5Mji/nwXTYSpvvWpnSjL9QFdKLa7bj5ahbsezSC9fjcFSnp60TxyCXna303xuO9L57kFCOdNy+OL8/fk0/DoPRU6QUJqWfg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RQa7aNvl9RxtkoDSFUXBMLQ3F95w7FMFx+265UkP3gc=; b=gwFo3BOa2xyfmkzAxTcPbfanrBvX/WQSHLfQrG2eZzNFtt4A2L1UB73LGDEFGMeUvwqX41xxuWJNJfsCbjwMMdEsXvAOEgFBc0gOH/FKkLR6Wa+PXLA5LnZM20VQpiCZD4zgIN5pLhMuUTlmYL7eZdHEaxVmA202lR+sRJzBq8U= Received: from VI1PR0801MB2127.eurprd08.prod.outlook.com (10.168.62.22) by VI1PR0801MB2032.eurprd08.prod.outlook.com (10.173.75.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2241.15; Mon, 9 Sep 2019 17:02:46 +0000 Received: from VI1PR0801MB2127.eurprd08.prod.outlook.com ([fe80::7c75:98da:fbc1:da02]) by VI1PR0801MB2127.eurprd08.prod.outlook.com ([fe80::7c75:98da:fbc1:da02%11]) with mapi id 15.20.2241.018; Mon, 9 Sep 2019 17:02:46 +0000 From: Wilco Dijkstra To: GCC Patches , Kyrylo Tkachov , Richard Earnshaw CC: nd Subject: [PATCH][ARM] Enable arm_legitimize_address for Thumb-2 Date: Mon, 09 Sep 2019 17:03:00 -0000 Message-ID: Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Wilco.Dijkstra@arm.com; X-Microsoft-Antispam-Untrusted: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020);SRVR:VI1PR0801MB2032; x-ms-exchange-transport-forked: True x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:403;OLM:403; X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(4636009)(39860400002)(396003)(376002)(346002)(136003)(366004)(54534003)(199004)(189003)(5660300002)(26005)(6506007)(102836004)(86362001)(66946007)(25786009)(2906002)(316002)(66446008)(64756008)(66556008)(66476007)(53936002)(186003)(55016002)(99286004)(33656002)(9686003)(7696005)(81166006)(8676002)(4326008)(8936002)(81156014)(110136005)(3846002)(6116002)(486006)(74316002)(476003)(305945005)(256004)(6436002)(7736002)(76116006)(71190400001)(66066001)(6636002)(71200400001)(52536014)(14454004)(478600001);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR0801MB2032;H:VI1PR0801MB2127.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info-Original: THMnZ+/9yWEOf4H0qlB2NoVHPVe/Y1H/Gss5k9lPqfbovqLdn8ABx49tEmw6El5c7K3p5pxq977+AHdbxEKYMQ5cR7/GF/3RNbdXL1HmJvjJNDGIxkG9hlEazhE4G8PC7ERSnJQmmTF9bzKA/sEq9xrpuhUr72lWjfNPWqdNeRGeLamfpyu2azIjp8mF7ALEUc/JibkXf7aAPk7aWP2FvZBBEJZ27v7fFbeVTwhzSPNSkl8ykFidk/dBWUYVRq4c1XzJaY8rPjMiPNsg34gmmwRp1XG1V/GQC5rJMys66OX2D8I+YbX40HJD1NuuvWl0I2N9w4h8YfTRleTh2FveSkCf5e7dbWdJaY6qoRevWLFrJLe7/ezg2RS6JS0giUoYYzzAMzVy/4mjwt9ZaMwbJpZHOv7PeQ7kcpCcCjSouzQ= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Wilco.Dijkstra@arm.com; Return-Path: Wilco.Dijkstra@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT042.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: a34e66ba-fa3c-4749-d41b-08d7354789de X-SW-Source: 2019-09/txt/msg00574.txt.bz2 Currently arm_legitimize_address doesn't handle Thumb-2 at all, resulting in inefficient code. Since Thumb-2 supports similar address offsets use the A= rm legitimization code for Thumb-2 to get significant codesize and performance gains. SPECINT2006 shows 0.4% gain on Cortex-A57, while SPECFP improves 0.= 2%. Bootstrap OK, OK for commit? ChangeLog: 2019-09-09 Wilco Dijkstra * config/arm/arm.c (arm_legitimize_address): Remove Thumb-2 bailout. -- diff --git a/gcc/config/arm/arm.c b/gcc/config/arm/arm.c index a5a6a0fab1b4b7ef07931522e7d47e59842d7f27..2601708e7e0716e4668b79e015e= 366d2164562fd 100644 --- a/gcc/config/arm/arm.c +++ b/gcc/config/arm/arm.c @@ -8652,13 +8652,8 @@ arm_legitimize_address (rtx x, rtx orig_x, machine_m= ode mode) return x; } =20 - if (!TARGET_ARM) - { - /* TODO: legitimize_address for Thumb2. */ - if (TARGET_THUMB2) - return x; - return thumb_legitimize_address (x, orig_x, mode); - } + if (TARGET_THUMB1) + return thumb_legitimize_address (x, orig_x, mode); =20 if (GET_CODE (x) =3D=3D PLUS) {