From: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
To: "Martin Liška" <mliska@suse.cz>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Cc: Jakub Jelinek <jakub@redhat.com>, nd <nd@arm.com>
Subject: Re: [PATCH][RFC] Come up with TARGET_HAS_FAST_MEMPCPY_ROUTINE (PR middle-end/90263).
Date: Fri, 10 May 2019 14:21:00 -0000 [thread overview]
Message-ID: <VI1PR0801MB2127FB18A7F4D124BF34B01E830C0@VI1PR0801MB2127.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <e8923b5d-2a1f-c1b4-9b7f-a970ae88f8a2@suse.cz>
Hi Martin,
> Patch can bootstrap on x86_64-linux-gnu and survives regression tests.
However I guess some existing tests checking for mempcpy may fail on
other targets, so might need to be changed.
> @Wilco: Can you please come up with a test-case for aarch64?
A simplified version gcc/testsuite/gcc.dg/fold-bcopy.c should be good enough
if existing tests don't provide enough cover. Literally just compiling the example
I gave and checking it calls memcpy using a target exclude will do, eg.
int *f (int *p, int *q, long n)
{
return __builtin_mempcpy (p, q, n);
}
/* { dg-final { scan-assembler "mempcpy" { target { i?86-*-* x86_64-*-* } } } } */
/* { dg-final { scan-assembler "memcpy" { target { ! { i?86-*-* x86_64-*-* } } } } } */
Wilco
prev parent reply other threads:[~2019-05-10 14:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-10 9:04 Martin Liška
2019-05-10 9:22 ` Jakub Jelinek
2019-05-13 10:14 ` Martin Liška
2019-05-13 13:02 ` Wilco Dijkstra
2019-05-13 13:08 ` Jakub Jelinek
2019-05-14 14:55 ` Martin Liška
2019-05-14 15:07 ` Martin Sebor
2019-05-15 11:35 ` Martin Liška
2019-05-17 15:38 ` Jeff Law
2019-05-20 21:28 ` Jakub Jelinek
2019-05-21 6:54 ` Martin Liška
2019-05-21 7:09 ` Jakub Jelinek
2019-05-21 7:32 ` Martin Liška
2019-05-20 8:43 ` Rainer Orth
2019-05-20 10:43 ` Martin Liška
2019-05-20 11:08 ` Rainer Orth
2019-05-10 14:21 ` Wilco Dijkstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR0801MB2127FB18A7F4D124BF34B01E830C0@VI1PR0801MB2127.eurprd08.prod.outlook.com \
--to=wilco.dijkstra@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=mliska@suse.cz \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).