From: Bin Cheng <Bin.Cheng@arm.com>
To: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Cc: nd <nd@arm.com>
Subject: [PATCH TEST]Rectify test case gcc.dg/tree-ssa/ivopt_mult_4.c
Date: Thu, 25 May 2017 18:15:00 -0000 [thread overview]
Message-ID: <VI1PR0802MB2176BDEBA40D883F11CF43B4E7FF0@VI1PR0802MB2176.eurprd08.prod.outlook.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 646 bytes --]
Hi,
I believe this tests has been wrongly modified previously. It is to test that the exit check on
pointer shouldn't be replaced by integer IV. Somehow GCC starts replacing the check on
integer IV with pointer IV. It's valid, though inefficient. And somehow we starting checking
this iv replacement. This patch rectifies it by specifically checking the check on pointer
shouldn't be replaced.
Bootstrap and test in series on x86_64. Is it OK?
Thanks,
bin
gcc/testsuite/ChangeLog
2017-05-11 Bin Cheng <bin.cheng@arm.com>
* gcc.dg/tree-ssa/ivopt_mult_4.c: Explicitly check comparison
on pointer should not be replaced.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0008-rectify-ivopt_mult_4.txt.patch --]
[-- Type: text/x-patch; name="0008-rectify-ivopt_mult_4.txt.patch", Size: 797 bytes --]
From e011b6952cc70a9582df51b672937934d4b85f29 Mon Sep 17 00:00:00 2001
From: Bin Cheng <binche01@e108451-lin.cambridge.arm.com>
Date: Wed, 19 Apr 2017 14:24:30 +0100
Subject: [PATCH 8/9] rectify-ivopt_mult_4.txt
---
gcc/testsuite/gcc.dg/tree-ssa/ivopt_mult_4.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gcc/testsuite/gcc.dg/tree-ssa/ivopt_mult_4.c b/gcc/testsuite/gcc.dg/tree-ssa/ivopt_mult_4.c
index effb052..321c786 100644
--- a/gcc/testsuite/gcc.dg/tree-ssa/ivopt_mult_4.c
+++ b/gcc/testsuite/gcc.dg/tree-ssa/ivopt_mult_4.c
@@ -21,4 +21,4 @@ long foo(long* p, long* p2, int N1, int N2)
return s;
}
-/* { dg-final { scan-tree-dump "Replacing exit test" "ivopts"} } */
+/* { dg-final { scan-tree-dump-not "Replacing exit test: if \\(p" "ivopts"} } */
--
1.9.1
next reply other threads:[~2017-05-25 18:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-25 18:15 Bin Cheng [this message]
2017-05-26 11:50 ` Richard Biener
2017-05-31 12:45 ` Bin.Cheng
2017-05-31 13:34 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR0802MB2176BDEBA40D883F11CF43B4E7FF0@VI1PR0802MB2176.eurprd08.prod.outlook.com \
--to=bin.cheng@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).