public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
To: "Hurugalawadi, Naveen" <Naveen.Hurugalawadi@cavium.com>,
	"Pinski, Andrew"	<Andrew.pinski@cavium.com>
Cc: Kyrylo Tkachov <Kyrylo.Tkachov@arm.com>,
	James Greenhalgh	<James.Greenhalgh@arm.com>, nd <nd@arm.com>,
	GCC Patches	<gcc-patches@gcc.gnu.org>
Subject: Re: [PING][PATCH][AArch64] Implement ALU_BRANCH fusion
Date: Tue, 25 Apr 2017 11:39:00 -0000	[thread overview]
Message-ID: <VI1PR0802MB26210A218B4677DB9A1EAE01831E0@VI1PR0802MB2621.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <CO2PR07MB26946C8BB993478233125861831E0@CO2PR07MB2694.namprd07.prod.outlook.com>

Hi Naveen,

> https://gcc.gnu.org/ml/gcc-patches/2017-03/msg01369.html

Same comment for this part, we want to return true if we match:

+      if (SET_DEST (curr_set) != (pc_rtx)
+	  || GET_CODE (SET_SRC (curr_set)) != IF_THEN_ELSE
+	  || ! REG_P (XEXP (XEXP (SET_SRC (curr_set), 0), 0))
+	  || ! REG_P (SET_DEST (prev_set))
+	  || REGNO (SET_DEST (prev_set))
+	     != REGNO (XEXP (XEXP (SET_SRC (curr_set), 0), 0)))
+	return false;

Note writing these complex conditions using positive logic makes them much
more readable - if you have to negate use !(X && Y && Z) rather than !X || !Y || !Z.

Wilco



        

  reply	other threads:[~2017-04-25 11:34 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <VI1PR0802MB26218E2C0940948518A0571783210@VI1PR0802MB2621.eurprd08.prod.outlook.com>
2017-03-15 15:20 ` [PATCH][AArch64] " Wilco Dijkstra
2017-03-21  5:37   ` Andrew Pinski
2017-03-27  7:33     ` Hurugalawadi, Naveen
2017-04-25  7:44       ` [PING][PATCH][AArch64] " Hurugalawadi, Naveen
2017-04-25 11:39         ` Wilco Dijkstra [this message]
2017-04-26 12:59           ` Hurugalawadi, Naveen
2017-04-26 14:29             ` Wilco Dijkstra
2017-04-27  7:32               ` Hurugalawadi, Naveen
2017-05-11  4:57                 ` [PING] [PATCH] [AArch64] " Hurugalawadi, Naveen
2017-05-26  7:14                   ` [PING 2] " Hurugalawadi, Naveen
2017-05-26 11:39                     ` Wilco Dijkstra
2017-06-14 10:29                       ` [PING 3] " Hurugalawadi, Naveen
2017-06-14 11:37                 ` [PING][PATCH][AArch64] " James Greenhalgh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=VI1PR0802MB26210A218B4677DB9A1EAE01831E0@VI1PR0802MB2621.eurprd08.prod.outlook.com \
    --to=wilco.dijkstra@arm.com \
    --cc=Andrew.pinski@cavium.com \
    --cc=James.Greenhalgh@arm.com \
    --cc=Kyrylo.Tkachov@arm.com \
    --cc=Naveen.Hurugalawadi@cavium.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=nd@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).